Add WorkloadIdentityConfig to Compute Instance and InstanceTemplate

[draksbahijakub-google]

Add WorkloadIdentityConfig to Compute Instance and InstanceTemplate

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `workload_identity_config` fields to `resource_compute_instance` and `resource_compute_instance_template` resources

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e23f870:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	11 files changed, 493 insertions(+)
google-beta provider	View Diff	12 files changed, 495 insertions(+)
terraform-google-conversion	View Diff	3 files changed, 59 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  workload_identity_config {
    identity                     = # value needed
    identity_certificate_enabled = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  workload_identity_config {
    identity                     = # value needed
    identity_certificate_enabled = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance
  • Expected Document Path: /website/docs/r/compute_instance.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_instance_template
  • Expected Document Path: /website/docs/r/compute_instance_template.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_region_instance_template
  • Expected Document Path: /website/docs/r/compute_region_instance_template.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1513	1414	94	5

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceTemplate_workloadIdentity
• TestAccComputeInstance_workloadIdentity_add
• TestAccComputeInstance_workloadIdentity_remove
• TestAccComputeInstance_workloadIdentity_update
• TestAccComputeRegionInstanceTemplate_workloadIdentity

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstanceTemplate_workloadIdentity
✅ Log	✅	TestAccComputeInstance_workloadIdentity_add
✅ Log	✅	TestAccComputeInstance_workloadIdentity_remove
✅ Log	✅	TestAccComputeInstance_workloadIdentity_update
✅ Log	✅	TestAccComputeRegionInstanceTemplate_workloadIdentity

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@draksbahijakub-google, @BBBmau VCR tests complete for e23f870!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 22d00f9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	14 files changed, 522 insertions(+)
google-beta provider	View Diff	15 files changed, 524 insertions(+)
terraform-google-conversion	View Diff	3 files changed, 59 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  workload_identity_config {
    identity                     = # value needed
    identity_certificate_enabled = # value needed
  }
}

Resource: google_compute_instance_from_template (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  workload_identity_config {
    identity                     = # value needed
    identity_certificate_enabled = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1513	1419	94	0

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@draksbahijakub-google, @BBBmau VCR tests complete for 22d00f9!

[BBBmau]

please address the missing fields in the test report as well as the missing fields in documentation

#18121 (comment)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 760b69f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	15 files changed, 607 insertions(+)
google-beta provider	View Diff	17 files changed, 705 insertions(+)
terraform-google-conversion	View Diff	3 files changed, 59 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_template (31 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  workload_identity_config {
    identity                     = # value needed
    identity_certificate_enabled = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1515	1419	94	2

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromMachineImage_workloadIdentity
• TestAccComputeInstanceFromTemplate_workloadIdentity

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstanceFromMachineImage_workloadIdentity
✅ Log	✅	TestAccComputeInstanceFromTemplate_workloadIdentity

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@draksbahijakub-google, @BBBmau VCR tests complete for 760b69f!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 233a0d3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	15 files changed, 607 insertions(+)
google-beta provider	View Diff	17 files changed, 705 insertions(+)
terraform-google-conversion	View Diff	3 files changed, 59 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_from_machine_image
  • Expected Document Path: /website/docs/r/compute_instance_from_machine_image.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]
• google_compute_instance_from_template
  • Expected Document Path: /website/docs/r/compute_instance_from_template.html.markdown
  • Fields: [workload_identity_config workload_identity_config.identity workload_identity_config.identity_certificate_enabled]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1515	1419	94	2

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromTemplate_workloadIdentity
• TestAccComputeRouterPeer_AddMd5AuthenticationKey

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstanceFromTemplate_workloadIdentity
✅ Log	✅	TestAccComputeRouterPeer_AddMd5AuthenticationKey

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@draksbahijakub-google, @BBBmau VCR tests complete for 233a0d3!

[draksbahijakub-google]

please address the missing fields in the test report as well as the missing fields in documentation

#18121 (comment)

@BBBmau Added missing tests. When it comes to detected missing docs - I verified that in both cases these docs are not listing all instances properties, but sending users to check general instances documentation for supported properties, so I left these 2 docs not changed to stay consistent.