Base resource requests on actual usage#2540
Open
NimJay wants to merge 5 commits into
Open
Conversation
|
🚲 PR staged at http://34.42.127.234 |
|
🚲 PR staged at http://34.42.127.234 |
Collaborator
Author
|
🚲 PR staged at http://34.42.127.234 |
|
🚲 PR staged at http://34.42.127.234 |
| cpu: 200m | ||
| memory: 450Mi | ||
| cpu: 30m | ||
| memory: 30Mi |
Contributor
There was a problem hiding this comment.
Getting OOMKilled with this on a brand new Kind cluster locally, let's have 70Mi in limits and 50Mi in requests like the other Python app emailservice has?
Contributor
|
FYI: I just deployed this in my own GKE Autopilot cluster, and I'm getting these values, In addition to the comment on the Should we have:
|
NimJay
commented
Jun 4, 2024
NimJay
commented
Jun 4, 2024
|
🚲 PR staged at http://34.42.127.234 |
Member
|
@NimJay do you remember where this PR was left off? |
gauravagerwala
added a commit
to gauravagerwala/microservices-demo
that referenced
this pull request
Dec 7, 2025
… on actual usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Background
10m(for CPU) and the next10MiBfor memory — to add a buffer.Change Summary
resource.requests.cpuandresource.requests.memoryvalues of each default microservices's Deployment.Testing Procedure