fix: sync kubernetes-manifest images with release versions#3361
Open
mdarshadkhan1998 wants to merge 5 commits into
Open
fix: sync kubernetes-manifest images with release versions#3361mdarshadkhan1998 wants to merge 5 commits into
mdarshadkhan1998 wants to merge 5 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
mdarshadkhan1998
left a comment
There was a problem hiding this comment.
This PR fixes an issue where individual service manifests in kubernetes-manifests/ were out of sync with the release manifest. I have updated all image references to use the full Artifact Registry paths and version tags (v0.10.5), ensuring that individual services can be deployed or redeployed independently.
Fixes # (#3361 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Previously, the individual YAML manifests in the kubernetes-manifests/ directory used generic image names (e.g., image: paymentservice) without a registry path or version tag. While the consolidated release/kubernetes-manifests.yaml file was correct, anyone attempting to deploy or redeploy a single service using the individual files would encounter ImagePullBackOff errors because Kubernetes could not resolve the image.
Fixes
#3360
Change Summary
Additional Notes
This change ensures consistency across the repository's deployment options. It specifically solves the issue where developers or users trying to test a specific microservice in isolation were unable to do so using the provided individual manifest files.
Testing Procedure
kubernetes-manifests/directory.paymentservice) using its individual manifest:kubectl apply -f paymentservice.yamlkubectl get pods -l app=paymentserviceus-central1-docker.pkg.dev/google-samples/microservices-demo/paymentservice:v0.10.5Related PRs or Issues
#3360