Don't include display name in alerting policy template user labels#1237
Merged
Conversation
See b/524991671 for context. GCP user labels must conform to strict API-level regex patterns [\p{Ll}\p{Lo}\p{N}_-]{0,63} so when agent display names start with an upper case letter we get an alert policy creation error. It would be brittle to attempt to sanitize arbitrary display names dynamically (e.g. toLowercase()) because there are other cases (special characters, length limits, whitespaces...).
Instead, we should just add display name to the alert documentation field so that oncallers can see which agent this is firing for in the notification. The labels can just be resource name and location which is deterministic and will always pass validation.
pintofloyed
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See b/524991671 for context. GCP user labels must conform to strict API-level regex patterns [\p{Ll}\p{Lo}\p{N}_-]{0,63} so when agent display names start with an upper case letter we get an alert policy creation error. It would be brittle to attempt to sanitize arbitrary display names dynamically (e.g. toLowercase()) because there are other cases (special characters, length limits, whitespaces...).
Instead, we should just add display name to the alert documentation field so that oncallers can see which agent this is firing for in the notification. The labels can just be resource name and location which is deterministic and will always pass validation.