fix: update nodemailer and remove decommissioned smtp-transport dependency

Author: angelcaamal

compute/mailjet.js

@@ -20,19 +20,15 @@
 
 // [START compute_send]
 const mailer = require('nodemailer');
-const smtp = require('nodemailer-smtp-transport');
-
 async function mailjet() {
-  const transport = mailer.createTransport(
-    smtp({
-      host: 'in.mailjet.com',
-      port: 2525,
-      auth: {
-        user: process.env.MAILJET_API_KEY || '<your-mailjet-api-key',
-        pass: process.env.MAILJET_API_SECRET || '<your-mailjet-api-secret>',
-      },
-    })
-  );
+  const transport = mailer.createTransport({
+    host: 'in.mailjet.com',
+    port: 2525,
+    auth: {
+      user: process.env.MAILJET_API_KEY || '<your-mailjet-api-key',
+      pass: process.env.MAILJET_API_SECRET || '<your-mailjet-api-secret>',
+    },
+  });
 
   const json = await transport.sendMail({
     from: 'ANOTHER_EMAIL@ANOTHER_EXAMPLE.COM', // From address

compute/package.json

@@ -16,8 +16,7 @@
   "dependencies": {
     "@google-cloud/compute": "^4.0.0",
     "@sendgrid/mail": "^8.0.0",
-    "nodemailer": "^6.0.0",
-    "nodemailer-smtp-transport": "^2.7.4",
+    "nodemailer": "^9.0.0",
     "sinon": "^19.0.2"
   },
   "devDependencies": {

compute/test/mailjet.test.js

@@ -24,8 +24,15 @@ describe('mailjet', () => {
   it('should send an email', () => {
     proxyquire('../mailjet', {
       nodemailer: {
-        createTransport: arg => {
-          assert.strictEqual(arg, 'test');
+        createTransport: options => {
+          assert.deepStrictEqual(options, {
+            host: 'in.mailjet.com',
+            port: 2525,
+            auth: {
+              user: 'foo',
+              pass: 'bar',
+            },
+          });
           return {
             sendMail: payload => {
               assert.deepStrictEqual(payload, {
@@ -39,17 +46,6 @@ describe('mailjet', () => {
           };
         },
       },
-      'nodemailer-smtp-transport': options => {
-        assert.deepStrictEqual(options, {
-          host: 'in.mailjet.com',
-          port: 2525,
-          auth: {
-            user: 'foo',
-            pass: 'bar',
-          },
-        });
-        return 'test';
-      },
     });
   });
 });