Skip to content

feat: add workflow execution samples with and without arguments#4302

Open
angelcaamal wants to merge 7 commits intomainfrom
feat/workflow-executions-samples
Open

feat: add workflow execution samples with and without arguments#4302
angelcaamal wants to merge 7 commits intomainfrom
feat/workflow-executions-samples

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented Apr 24, 2026

Description

Fixes Internal: b/505880299

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Apr 24, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new JavaScript and TypeScript samples for executing Google Cloud Workflows with and without arguments, along with corresponding tests and configuration updates. The feedback highlights critical issues in error handling where caught errors are not rethrown, preventing the process from exiting with a failure code. Additionally, it is recommended to cap the exponential backoff delay during execution polling to avoid excessively long wait times.

Comment thread workflows/quickstart/executeWithArguments.ts
Comment thread workflows/quickstart/executeWithoutArguments.ts
Comment thread workflows/quickstart/executeWithArguments.ts
Comment thread workflows/quickstart/executeWithoutArguments.ts
Added a specific ts-node override in tsconfig.json to force CommonJS compilation during tests, bypassing Node 20 strict ESM cycle restrictions (ERR_REQUIRE_CYCLE_MODULE). Updated moduleResolution to node16 to resolve TypeScript deprecation warnings and added missing types.
@angelcaamal angelcaamal marked this pull request as ready for review April 29, 2026 20:00
@angelcaamal angelcaamal requested review from a team as code owners April 29, 2026 20:00
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 29, 2026

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant