feat: add workflow execution samples with and without arguments#4302
feat: add workflow execution samples with and without arguments#4302angelcaamal wants to merge 7 commits intomainfrom
Conversation
Increased the timeout to account for the latency of workflow execution and polling.
There was a problem hiding this comment.
Code Review
This pull request introduces new JavaScript and TypeScript samples for executing Google Cloud Workflows with and without arguments, along with corresponding tests and configuration updates. The feedback highlights critical issues in error handling where caught errors are not rethrown, preventing the process from exiting with a failure code. Additionally, it is recommended to cap the exponential backoff delay during execution polling to avoid excessively long wait times.
Added a specific ts-node override in tsconfig.json to force CommonJS compilation during tests, bypassing Node 20 strict ESM cycle restrictions (ERR_REQUIRE_CYCLE_MODULE). Updated moduleResolution to node16 to resolve TypeScript deprecation warnings and added missing types.
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes Internal: b/505880299
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.