From d4392aa9533b42bfff8b10e7e667f12e70c2b5e2 Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Tue, 16 Jun 2026 19:31:05 +0000 Subject: [PATCH 1/3] fix(test): resolve linting issues in translate_batch_translate_text --- translate/test/v3/translate_batch_translate_text.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/translate/test/v3/translate_batch_translate_text.test.js b/translate/test/v3/translate_batch_translate_text.test.js index 846b3658a73..4c5b99064f8 100644 --- a/translate/test/v3/translate_batch_translate_text.test.js +++ b/translate/test/v3/translate_batch_translate_text.test.js @@ -46,7 +46,7 @@ describe(REGION_TAG, () => { const bucketName = `translation-${bucketUuid}/BATCH_TRANSLATE_OUTPUT/`; const storage = new Storage(); - before(async () => { + (before(async () => { const projectId = await translationClient.getProjectId(); //Create bucket if needed @@ -88,5 +88,5 @@ describe(REGION_TAG, () => { if (length > 0) { await Promise.all(files.map(file => file.delete())); } - }); + })); }); From d55a979c2682dca97bb2cbde537e2a39be21008c Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Tue, 16 Jun 2026 20:21:36 +0000 Subject: [PATCH 2/3] fix: fix formatting and syntax issues in translate_batch_translate_text.test.js --- .../v3/translate_batch_translate_text.test.js | 55 ++++++++++--------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/translate/test/v3/translate_batch_translate_text.test.js b/translate/test/v3/translate_batch_translate_text.test.js index 4c5b99064f8..3cc411a20ab 100644 --- a/translate/test/v3/translate_batch_translate_text.test.js +++ b/translate/test/v3/translate_batch_translate_text.test.js @@ -46,7 +46,7 @@ describe(REGION_TAG, () => { const bucketName = `translation-${bucketUuid}/BATCH_TRANSLATE_OUTPUT/`; const storage = new Storage(); - (before(async () => { + before(async () => { const projectId = await translationClient.getProjectId(); //Create bucket if needed @@ -61,32 +61,33 @@ describe(REGION_TAG, () => { console.error(error); } }); - }), - it('should batch translate the input text', async function () { - this.retries(3); - const projectId = await translationClient.getProjectId(); - await clearBucket(projectId, storage, bucketUuid); - const inputUri = 'gs://cloud-samples-data/translation/text.txt'; + }); - const outputUri = `gs://${projectId}/${bucketName}`; - const output = execSync( - `node v3/${REGION_TAG}.js ${projectId} ${location} ${inputUri} ${outputUri}` - ); - assert.match(output, /Total Characters: 13/); - assert.match(output, /Translated Characters: 13/); - }), - // Delete the folder from GCS for cleanup - after(async () => { - const projectId = await translationClient.getProjectId(); - const options = { - prefix: `translation-${bucketUuid}`, - }; + it('should batch translate the input text', async function () { + this.retries(3); + const projectId = await translationClient.getProjectId(); + await clearBucket(projectId, storage, bucketUuid); + const inputUri = 'gs://cloud-samples-data/translation/text.txt'; + + const outputUri = `gs://${projectId}/${bucketName}`; + const output = execSync( + `node v3/${REGION_TAG}.js ${projectId} ${location} ${inputUri} ${outputUri}` + ); + assert.match(output, /Total Characters: 13/); + assert.match(output, /Translated Characters: 13/); + }); + // Delete the folder from GCS for cleanup + after(async () => { + const projectId = await translationClient.getProjectId(); + const options = { + prefix: `translation-${bucketUuid}`, + }; - const bucket = await storage.bucket(projectId); - const [files] = await bucket.getFiles(options); - const length = files.length; - if (length > 0) { - await Promise.all(files.map(file => file.delete())); - } - })); + const bucket = await storage.bucket(projectId); + const [files] = await bucket.getFiles(options); + const length = files.length; + if (length > 0) { + await Promise.all(files.map(file => file.delete())); + } + }); }); From aef1379c1e29305c49707eed259f2d8622319283 Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Tue, 16 Jun 2026 21:22:22 +0000 Subject: [PATCH 3/3] refactor: use await bucket.deleteFiles instead of for-loop --- translate/test/v3/translate_batch_translate_text.test.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/translate/test/v3/translate_batch_translate_text.test.js b/translate/test/v3/translate_batch_translate_text.test.js index 3cc411a20ab..0eda1c09734 100644 --- a/translate/test/v3/translate_batch_translate_text.test.js +++ b/translate/test/v3/translate_batch_translate_text.test.js @@ -84,10 +84,6 @@ describe(REGION_TAG, () => { }; const bucket = await storage.bucket(projectId); - const [files] = await bucket.getFiles(options); - const length = files.length; - if (length > 0) { - await Promise.all(files.map(file => file.delete())); - } + await bucket.deleteFiles(options); }); });