Skip to content

fix(test): resolve linting issues in translate_batch_translate_text.test.js #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iennae merged 6 commits into from
Jun 18, 2026
Merged

fix(test): resolve linting issues in translate_batch_translate_text.test.js #4345

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4392aa
fix(test): resolve linting issues in translate_batch_translate_text
angelcaamal Jun 16, 2026
d55a979
fix: fix formatting and syntax issues in translate_batch_translate_te…
angelcaamal Jun 16, 2026
aef1379
refactor: use await bucket.deleteFiles instead of for-loop
angelcaamal Jun 16, 2026
20b44e5
Merge branch 'main' into fix/translate-test-lint
angelcaamal Jun 17, 2026
6ea1613
Merge branch 'main' into fix/translate-test-lint
iennae Jun 18, 2026
fff4554
Merge branch 'main' into fix/translate-test-lint
angelcaamal Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 27 additions & 26 deletions translate/test/v3/translate_batch_translate_text.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,32 +61,33 @@ describe(REGION_TAG, () => {
console.error(error);
}
});
}),
it('should batch translate the input text', async function () {
this.retries(3);
const projectId = await translationClient.getProjectId();
await clearBucket(projectId, storage, bucketUuid);
const inputUri = 'gs://cloud-samples-data/translation/text.txt';
});

const outputUri = `gs://${projectId}/${bucketName}`;
const output = execSync(
`node v3/${REGION_TAG}.js ${projectId} ${location} ${inputUri} ${outputUri}`
);
assert.match(output, /Total Characters: 13/);
assert.match(output, /Translated Characters: 13/);
}),
// Delete the folder from GCS for cleanup
after(async () => {
const projectId = await translationClient.getProjectId();
const options = {
prefix: `translation-${bucketUuid}`,
};
it('should batch translate the input text', async function () {
this.retries(3);
const projectId = await translationClient.getProjectId();
await clearBucket(projectId, storage, bucketUuid);
const inputUri = 'gs://cloud-samples-data/translation/text.txt';

const outputUri = `gs://${projectId}/${bucketName}`;
const output = execSync(
`node v3/${REGION_TAG}.js ${projectId} ${location} ${inputUri} ${outputUri}`
);
assert.match(output, /Total Characters: 13/);
assert.match(output, /Translated Characters: 13/);
});
// Delete the folder from GCS for cleanup
after(async () => {
const projectId = await translationClient.getProjectId();
const options = {
prefix: `translation-${bucketUuid}`,
};

const bucket = await storage.bucket(projectId);
const [files] = await bucket.getFiles(options);
const length = files.length;
if (length > 0) {
await Promise.all(files.map(file => file.delete()));
}
});
const bucket = await storage.bucket(projectId);
const [files] = await bucket.getFiles(options);
const length = files.length;
if (length > 0) {
await Promise.all(files.map(file => file.delete()));
}
Comment thread
angelcaamal marked this conversation as resolved.
Outdated
});
});
Loading