Skip to content

fix(dlp): resolve CommonJS compatibility issues and stabilize test #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelcaamal merged 9 commits into from
Jul 15, 2026
Merged

fix(dlp): resolve CommonJS compatibility issues and stabilize test #4350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dbb5826
fix(dlp): downgrade mime to v3 to restore CommonJS compatibility
angelcaamal Jun 19, 2026
50f91ab
fix(dlp): downgrade mime and pixelmatch to restore CommonJS compatibi…
angelcaamal Jun 19, 2026
115ebfb
test(dlp): use realistic mock SSN to fix DLP API likelihood filtering
angelcaamal Jun 19, 2026
544bfd3
Merge branch 'main' into fix-dlp-mime-esm
angelcaamal Jun 22, 2026
b53b5f5
Merge branch 'main' into fix-dlp-mime-esm
angelcaamal Jun 24, 2026
0971e5c
Merge branch 'main' into fix-dlp-mime-esm
angelcaamal Jun 25, 2026
9dddc2a
Merge branch 'main' into fix-dlp-mime-esm
angelcaamal Jul 14, 2026
143b350
Merge branch 'main' into fix-dlp-mime-esm
angelcaamal Jul 14, 2026
acfc555
Merge branch 'main' into fix-dlp-mime-esm
angelcaamal Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dlp/inspectWithCustomHotwords.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function main(projectId) {
],
rows: [
{
values: [{stringValue: '111-11-1111'}, {stringValue: '222-22-2222'}],
values: [{stringValue: '111-11-1111'}, {stringValue: '458-90-3124'}],
},
],
};
Expand Down
4 changes: 2 additions & 2 deletions dlp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"devDependencies": {
"c8": "^10.0.0",
"chai": "^4.5.0",
"mime": "^4.0.0",
"mime": "^3.0.0",
"mocha": "^10.0.0",
"pixelmatch": "^6.0.0",
"pixelmatch": "^5.3.0",
"pngjs": "^7.0.0",
"proxyquire": "^2.1.3",
"sinon": "^18.0.0",
Expand Down
2 changes: 1 addition & 1 deletion dlp/system-test/inspect.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,7 @@ describe('inspect', () => {
it('should inspect a table excluding findings in a particular row', () => {
const output = execSync(`node inspectWithCustomHotwords.js ${projectId}`);
assert.match(output, /Findings: 1/);
assert.match(output, /Quote: 222-22-2222/);
assert.match(output, /Quote: 458-90-3124/);
assert.notMatch(output, /Quote: 111-11-1111/);
});

Expand Down
Loading