Skip to content

chore: update uuid to ^11.1.1 in fourth chunk of packages - #4356

Merged
grayside merged 3 commits into
mainfrom
fix/uuid-update-chunk-4
Jun 22, 2026
Merged

chore: update uuid to ^11.1.1 in fourth chunk of packages#4356
grayside merged 3 commits into
mainfrom
fix/uuid-update-chunk-4

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: cloudkms Issues related to the Cloud Key Management Service API. api: healhcare api: iam Issues related to the Identity and Access Management API. labels Jun 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the devDependency uuid from ^10.0.0 to ^11.1.1 across multiple package.json files, and reformats iam/deny/package.json. The review feedback correctly points out that uuid v11 requires Node.js >= 18.0.0, which creates a compatibility conflict with the older Node.js versions currently specified in the engines field of several packages (such as >=16.0.0, >=12.0.0, and >=10). To prevent runtime or installation issues, the Node.js engine requirements should be updated to >=18.0.0 or the uuid upgrade should be reverted.

Comment thread iam/deny/package.json Outdated
Comment thread healthcare/consent/package.json
Comment thread media/video-stitcher/package.json
@angelcaamal
angelcaamal marked this pull request as ready for review June 22, 2026 22:08
@angelcaamal
angelcaamal requested review from a team as code owners June 22, 2026 22:08
@grayside
grayside merged commit 888d89c into main Jun 22, 2026
37 of 39 checks passed
@grayside
grayside deleted the fix/uuid-update-chunk-4 branch June 22, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudkms Issues related to the Cloud Key Management Service API. api: healhcare api: iam Issues related to the Identity and Access Management API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants