Skip to content

cleanup: remove obsolete function calling samples - #4387

Merged
angelcaamal merged 1 commit into
mainfrom
cleanup/remove-obsolete-function-calling-samples
Jul 24, 2026
Merged

cleanup: remove obsolete function calling samples#4387
angelcaamal merged 1 commit into
mainfrom
cleanup/remove-obsolete-function-calling-samples

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Removes obsolete Function Calling samples that are no longer in use or referenced in the documentation.

Changes

  • Deleted decommissioned Function Calling sample files.
  • Removed corresponding tests and references.

Fixes Internal: b/537369086

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: genai labels Jul 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several files and tests related to Generative AI Function Calling, specifically deleting the basic and streaming function calling implementation files along with their corresponding test suites. As there are no review comments, no further feedback is provided.

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, No active references to this files 👍

@amcolin
amcolin marked this pull request as ready for review July 24, 2026 16:42
@amcolin
amcolin requested review from a team as code owners July 24, 2026 16:42
@snippet-bot

snippet-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@angelcaamal
angelcaamal merged commit 2b54289 into main Jul 24, 2026
22 checks passed
@angelcaamal
angelcaamal deleted the cleanup/remove-obsolete-function-calling-samples branch July 24, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: genai samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants