Skip to content

Commit a3d3c7a

Browse files
authored
chore: update e2e test to use upstreamed resource detector (#840)
1 parent 26206dc commit a3d3c7a

3 files changed

Lines changed: 25 additions & 25 deletions

File tree

e2e-test-server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@
3636
"dependencies": {
3737
"@google-cloud/functions-framework": "^3.1.3",
3838
"@google-cloud/opentelemetry-cloud-trace-exporter": "^3.0.0",
39-
"@google-cloud/opentelemetry-resource-util": "^3.0.0",
4039
"@google-cloud/pubsub": "^4.0.0",
4140
"@grpc/grpc-js": "^1.3.2",
4241
"@opentelemetry/api": "^1.9.0",
4342
"@opentelemetry/context-async-hooks": "^2.0.0",
4443
"@opentelemetry/core": "^2.0.0",
44+
"@opentelemetry/resource-detector-gcp": "^0.44.0",
4545
"@opentelemetry/resources": "^2.0.0",
4646
"@opentelemetry/sdk-trace-base": "^2.0.0",
4747
"express": "^4.21.0",

e2e-test-server/src/scenarios.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
TraceExporter,
2929
TraceExporterOptions,
3030
} from '@google-cloud/opentelemetry-cloud-trace-exporter';
31-
import {GcpDetectorSync} from '@google-cloud/opentelemetry-resource-util';
31+
import {gcpDetector} from '@opentelemetry/resource-detector-gcp';
3232
import * as constants from './constants';
3333
import {context, SpanKind, Tracer} from '@opentelemetry/api';
3434
import {AsyncHooksContextManager} from '@opentelemetry/context-async-hooks';
@@ -117,8 +117,8 @@ async function complexTrace(request: Request): Promise<Response> {
117117
}
118118

119119
async function detectResource(request: Request): Promise<Response> {
120-
const resource = await detectResources({
121-
detectors: [new GcpDetectorSync(), envDetector],
120+
const resource = detectResources({
121+
detectors: [gcpDetector, envDetector],
122122
});
123123

124124
return withTracer(

package-lock.json

Lines changed: 21 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)