Add unit when creating metric descriptors (#218)

Author: aabmass

opentelemetry-exporter-gcp-monitoring/src/opentelemetry/exporter/cloud_monitoring/__init__.py

@@ -145,6 +145,7 @@ def _get_metric_descriptor(
             type=descriptor_type,
             display_name=metric.name,
             description=metric.description or "",
+            unit=metric.unit or "",
         )
         seen_keys: Set[str] = set()
         for data_point in metric.data.data_points:

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_counter[float].json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/mycounter",
+        "unit": "{myunit}",
         "valueType": "DOUBLE"
       },
       "name": "projects/fakeproject"
@@ -54,7 +55,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_counter[int].json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/mycounter",
+        "unit": "{myunit}",
         "valueType": "INT64"
       },
       "name": "projects/fakeproject"
@@ -54,7 +55,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_histogram_default_buckets.json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/myhistogram",
+        "unit": "{myunit}",
         "valueType": "DISTRIBUTION"
       },
       "name": "projects/fakeproject"
@@ -96,7 +97,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_histogram_single_bucket.json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/myhistogram",
+        "unit": "{myunit}",
         "valueType": "DISTRIBUTION"
       },
       "name": "projects/fakeproject"
@@ -68,7 +69,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_invalid_label_keys.json

@@ -11,6 +11,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/mycounter",
+        "unit": "{myunit}",
         "valueType": "INT64"
       },
       "name": "projects/fakeproject"
@@ -46,7 +47,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_observable_counter[float].json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/myobservablecounter",
+        "unit": "{myunit}",
         "valueType": "DOUBLE"
       },
       "name": "projects/fakeproject"
@@ -54,7 +55,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_observable_counter[int].json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "CUMULATIVE",
         "type": "workload.googleapis.com/myobservablecounter",
+        "unit": "{myunit}",
         "valueType": "INT64"
       },
       "name": "projects/fakeproject"
@@ -54,7 +55,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_observable_gauge[float].json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "GAUGE",
         "type": "workload.googleapis.com/myobservablegauge",
+        "unit": "{myunit}",
         "valueType": "DOUBLE"
       },
       "name": "projects/fakeproject"
@@ -53,7 +54,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }

opentelemetry-exporter-gcp-monitoring/tests/__snapshots__/test_cloud_monitoring/test_observable_gauge[int].json

@@ -17,6 +17,7 @@
         ],
         "metricKind": "GAUGE",
         "type": "workload.googleapis.com/myobservablegauge",
+        "unit": "{myunit}",
         "valueType": "INT64"
       },
       "name": "projects/fakeproject"
@@ -53,7 +54,8 @@
               "node_id": ""
             },
             "type": "generic_node"
-          }
+          },
+          "unit": "{myunit}"
         }
       ]
     }