Skip to content

Commit ce75024

Browse files
committed
Fix samples again
1 parent c11054c commit ce75024

4 files changed

Lines changed: 22 additions & 11 deletions

File tree

opentelemetry-resourcedetector-gcp/README.rst

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,20 @@ Usage
3030
------------
3131

3232
.. code:: python
33-
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
3433
from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter
3534
from opentelemetry.sdk.trace import TracerProvider
3635
from opentelemetry.sdk.trace.export import BatchSpanProcessor
3736
from opentelemetry import trace
38-
39-
resource = GoogleCloudResourceDetector().detect()
37+
from opentelemetry.sdk.resources import SERVICE_INSTANCE_ID, Resource
38+
39+
# This will use the GooglecloudResourceDetector under the covers.
40+
resource = Resource.create(
41+
attributes={
42+
# Use the PID as the service.instance.id to avoid duplicate timeseries
43+
# from different Gunicorn worker processes.
44+
SERVICE_INSTANCE_ID: f"worker-{os.getpid()}",
45+
}
46+
)
4047
traceProvider = TracerProvider(resource=resource)
4148
processor = BatchSpanProcessor(OTLPSpanExporter())
4249
traceProvider.add_span_processor(processor)

samples/instrumentation-quickstart/setup_opentelemetry.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,19 @@
2323
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor
2424
from opentelemetry.sdk.metrics import MeterProvider
2525
from opentelemetry.sdk.metrics.export import PeriodicExportingMetricReader
26+
from opentelemetry.sdk.resources import SERVICE_INSTANCE_ID, Resource
2627
from opentelemetry.sdk.trace import TracerProvider
2728
from opentelemetry.sdk.trace.export import BatchSpanProcessor
2829

29-
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
30-
3130
# [START opentelemetry_instrumentation_setup_opentelemetry]
3231
def setup_opentelemetry() -> None:
33-
resource = GoogleCloudResourceDetector().detect()
34-
32+
resource = Resource.create(
33+
attributes={
34+
# Use the PID as the service.instance.id to avoid duplicate timeseries
35+
# from different Gunicorn worker processes.
36+
SERVICE_INSTANCE_ID: f"worker-{os.getpid()}",
37+
}
38+
)
3539
# Set up OpenTelemetry Python SDK
3640
tracer_provider = TracerProvider(resource=resource)
3741
tracer_provider.add_span_processor(BatchSpanProcessor(OTLPSpanExporter()))

samples/otlptrace/example_grpc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import (
2525
OTLPSpanExporter,
2626
)
27+
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
2728
from opentelemetry.sdk.trace import TracerProvider
2829
from opentelemetry.sdk.trace.export import BatchSpanProcessor
29-
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
3030

3131
"""
3232
This is a sample script that exports OTLP traces encoded as protobufs via gRPC.
3333
"""
3434

3535
credentials, _ = google.auth.default()
3636
request = google.auth.transport.requests.Request()
37-
resource = GoogleCloudResourceDetector().detect()
37+
resource = Resource.create(attributes={SERVICE_NAME: "otlp-gcp-grpc-sample"})
3838

3939
auth_metadata_plugin = AuthMetadataPlugin(credentials=credentials, request=request)
4040
channel_creds = grpc.composite_channel_credentials(

samples/otlptrace/example_http.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919
from opentelemetry.exporter.otlp.proto.http.trace_exporter import (
2020
OTLPSpanExporter,
2121
)
22-
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
2322
from google.auth.transport.requests import AuthorizedSession
23+
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
2424
from opentelemetry.sdk.trace import TracerProvider
2525
from opentelemetry.sdk.trace.export import BatchSpanProcessor
2626

2727
credentials, _ = google.auth.default()
2828
trace_provider = TracerProvider(
29-
resource=GoogleCloudResourceDetector().detect()
29+
resource=Resource.create(attributes={SERVICE_NAME: "otlp-gcp-http-sample"})
3030
)
3131
processor = BatchSpanProcessor(
3232
OTLPSpanExporter(

0 commit comments

Comments
 (0)