Update code.js#1704
Conversation
Refactor netblock storage and add recursive SPF resolution - Store all IP ranges in a single JSON script property to prevent IPv6 key corruption - Add recursive parsing of SPF include directives - Remove legacy per-IP property storage - Improve change detection reliability - Enhance email report formatting and readability
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@lonix86 If you can get the CLA done, I can take a look at merging your PR. Without the CLA, my hands are tied. |
|
Signed 👍🏻
|
| .timeBased() | ||
| .everyDays(1) | ||
| .atHour(8) | ||
| .inTimezone('Europe/Rome') |
There was a problem hiding this comment.
Looks like DAILY_TRIGGER_TZ has been replaced by a specific hard coded zone. This doesn't feel right, but I could be mistaken.
There was a problem hiding this comment.
@lonix86 Do you mind taking a look at this?
Thank you!
There was a problem hiding this comment.
@lonix86 If you can replace the hard coded time zone, I'll gladly get this merged.
|
@jdw353 Do you mind taking a quick look at this PR? I know it's been forever, but you're the only previous contributor to this code, and I'd like a second pair of eyes on the apparent TZ change. |
replaced the hard coded time zone
|
/gcbrun |
2 participants
Refactor netblock storage and add recursive SPF resolution