Skip to content

Commit a1f09c5

Browse files
daniel-sancheohmayrgcf-owl-bot[bot]gkevinzhengparthea
authored
feat: Add support for python 3.14 (#1065)
This PR adds python 3.14 support to the python-logging package. Expanding off of Omair's work here: googleapis/python-logging#1055 --------- Co-authored-by: ohmayr <omairn@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Kevin Zheng <kevzheng@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent f4d1ed2 commit a1f09c5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

logging/samples/snippets/export_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ def _create_sink_name():
5050

5151

5252
@backoff.on_exception(backoff.expo, Exception, max_time=60, raise_on_giveup=False)
53-
def _delete_object(obj):
54-
obj.delete()
53+
def _delete_object(obj, **kwargs):
54+
obj.delete(**kwargs)
5555

5656

5757
# Runs once for entire test suite
@@ -79,7 +79,7 @@ def cleanup_old_sinks():
7979
# Bucket timestamp is int(time.time() * 1000)
8080
bucket_timestamp = int(match.group(1))
8181
if TIMESTAMP - bucket_timestamp // 1000 > CLEANUP_THRESHOLD:
82-
_delete_object(bucket)
82+
_delete_object(bucket, force=True)
8383

8484

8585
@pytest.fixture

logging/samples/snippets/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def get_pytest_env_vars() -> Dict[str, str]:
8989

9090
# DO NOT EDIT - automatically generated.
9191
# All versions used to test samples.
92-
ALL_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
92+
ALL_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
9393

9494
# Any default versions that should be ignored.
9595
IGNORED_VERSIONS = TEST_CONFIG["ignored_versions"]

0 commit comments

Comments
 (0)