Skip to content

Commit deec31e

Browse files
authored
fix: Update PULL_REQUEST_TEMPLATE.md
1 parent 2806cb8 commit deec31e

1 file changed

Lines changed: 13 additions & 11 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,17 @@
22

33
Fixes #<ISSUE-NUMBER>
44

5-
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
6-
75
## Checklist
8-
- [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md)
9-
- [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file)
10-
- [ ] **Tests** pass: `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup))
11-
- [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup))
12-
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
13-
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
14-
- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
15-
- [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample
16-
- [ ] Please **merge** this PR for me once it is approved
6+
7+
### Testing
8+
- [ ] **I have tested this change on a live environment and verified it works as intended.**
9+
10+
### Compliance & Style
11+
- [ ] I have followed the [Sample Guidelines](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md).
12+
- [ ] The README is updated with [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file) (if applicable).
13+
- [ ] **If this PR adds a new sample directory:** I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS).
14+
15+
---
16+
17+
## Post-Approval Actions
18+
- [ ] Please **merge** this PR for me once it is approved

0 commit comments

Comments
 (0)