fix: permit optional ports for sidecars so we can run sidecars#450
Open
bdashrad wants to merge 5 commits into
Open
fix: permit optional ports for sidecars so we can run sidecars#450bdashrad wants to merge 5 commits into
bdashrad wants to merge 5 commits into
Conversation
fix[sidecars]: Permit optional ports for sidecars.
bdashrad
requested review from
a team,
anamer,
ayushmjain,
krprabhat-eng,
prabhu34 and
q2w
as code owners
Author
|
@q2w @prabhu34 @krprabhat-eng @ayushmjain @anamer if you have a moment, could you take a look at this PR, or the prior one #381? We need this to run sidecar containers with the v2 module. I've been running it myself for a few weeks in the fork, but hoping to get it merged back to the main branch. |
Author
|
Hi, I'm looking to see if there is anything I can do to help make this easier to review or prepare for merging. |
Collaborator
|
/gcbrun |
amandakarina
changed the title
amandakarina
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt at #381 to resolve #302.