Skip to content

fix: make prometheus image variable dynamic#452

Open
cbid71 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
cbid71:fix/variable-prometheus-image
Open

fix: make prometheus image variable dynamic#452
cbid71 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
cbid71:fix/variable-prometheus-image

Conversation

@cbid71
Copy link
Copy Markdown

@cbid71 cbid71 commented Mar 23, 2026

No description provided.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 23, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cbid71 cbid71 force-pushed the fix/variable-prometheus-image branch from d1fd083 to fa04913 Compare March 23, 2026 21:34
@amandakarina
Copy link
Copy Markdown
Collaborator

/gcbrun

@amandakarina
Copy link
Copy Markdown
Collaborator

Linting is failing:

2026/04/14 16:26:56 
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/v2/README.md /tmp/tmp.1YE2XvCIyk/generate_docs/workspace/modules/v2/README.md
71a72
> | prometheus\_sidecar\_image | Image associated to the Prometheus sidecar. | `string` | `"us-docker.pkg.dev/cloud-ops-agents-artifacts/cloud-run-gmp-sidecar/cloud-run-gmp-sidecar:1.1.1"` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

@cbid71 cbid71 force-pushed the fix/variable-prometheus-image branch from 19a1a8f to 6bea7f9 Compare April 16, 2026 22:34
@cbid71
Copy link
Copy Markdown
Author

cbid71 commented Apr 16, 2026

ok I've played make docker_generate_docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants