feat: expose default URI toggle for Cloud Run v2#477
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Author
|
This is ready for maintainer review from my side. The remaining terraform-google-cloud-run-int-trigger check appears to require project-side approval/run permissions; could someone take a look or trigger it when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
default_uri_disabledinput to the v2 module and passes it through togoogle_cloud_run_v2_service.The variable defaults to
false, so existing module behavior is unchanged unless callers opt in.Tests:
generate_docs --per-module-requirementsusinggcr.io/cloud-foundation-cicd/cft/developer-tools:1.25test_lint.shwithDISABLE_TFLINT=1using the same image; the changedmodules/v2module and v2 examples validatedtest_lint.shwithoutDISABLE_TFLINT;modules/v2tflint passed, whileexamples/v2tflint crashed under local Docker amd64 emulationgit diff --checkRefs #229.