fix(deps)!: Update Terraform terraform-google-modules/kubernetes-engine/google to v44#653
Conversation
|
/gcbrun |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the terraform-google-modules/kubernetes-engine/google module from version ~> 36.0 to ~> 44.0. This is a major version update. My review confirms the version bump and also identifies an opportunity for improvement. The GKE cluster modules are using deprecated beta- submodule paths. I've recommended updating these paths to the current, non-beta versions to improve long-term maintainability, which is a good practice when performing a major version upgrade.
| module "gke-standard" { | ||
| source = "terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster" | ||
| version = "~> 36.0" | ||
| version = "~> 44.0" |
There was a problem hiding this comment.
The beta-private-cluster submodule used on the preceding line is deprecated. As you are performing a major version upgrade, this is a good opportunity to switch to the recommended private-cluster submodule for better maintainability.
Suggestion:
Update line 250 to:
source = "terraform-google-modules/kubernetes-engine/google//modules/private-cluster"| module "gke-autopilot" { | ||
| source = "terraform-google-modules/kubernetes-engine/google//modules/beta-autopilot-private-cluster" | ||
| version = "~> 36.0" | ||
| version = "~> 44.0" |
There was a problem hiding this comment.
Similarly, the beta-autopilot-private-cluster submodule used on the preceding line is deprecated. Please update it to autopilot-private-cluster to align with the module's latest structure.
Suggestion:
Update line 339 to:
source = "terraform-google-modules/kubernetes-engine/google//modules/autopilot-private-cluster"07122c4 to
6f63256
Compare
|
/gcbrun |
6f63256 to
c7baaea
Compare
|
/gcbrun |
c7baaea to
74fddb1
Compare
|
/gcbrun |
74fddb1 to
ffd3407
Compare
|
/gcbrun |
ffd3407 to
413df41
Compare
|
/gcbrun |
413df41 to
68558e3
Compare
|
/gcbrun |
68558e3 to
bc8a248
Compare
|
/gcbrun |
bc8a248 to
d0a1615
Compare
|
/gcbrun |
d0a1615 to
5a79409
Compare
|
/gcbrun |
5a79409 to
8219bd3
Compare
|
/gcbrun |
…-engine-google-44.x
|
/gcbrun |
…-engine-google-44.x
|
/gcbrun |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
~> 40.0→~> 44.0Release Notes
terraform-google-modules/terraform-google-kubernetes-engine (terraform-google-modules/kubernetes-engine/google)
v44.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
v43.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
v42.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
v41.0.2Compare Source
Bug Fixes
v41.0.1Compare Source
Bug Fixes
v41.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.