Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 2-multitenant/modules/env_baseline/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ resource "google_project_iam_member" "model_armor_service_network_extension_role

module "gke-standard" {
source = "terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster"
version = "~> 40.0"
version = "~> 44.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The beta-private-cluster submodule used on the preceding line is deprecated. As you are performing a major version upgrade, this is a good opportunity to switch to the recommended private-cluster submodule for better maintainability.

Suggestion:
Update line 250 to:

source  = "terraform-google-modules/kubernetes-engine/google//modules/private-cluster"


for_each = var.cluster_type != "AUTOPILOT" ? local.subnets : {}
name = "cluster-${data.google_compute_subnetwork.default[each.key].region}-${var.env}"
Expand Down Expand Up @@ -337,7 +337,7 @@ module "gke-standard" {

module "gke-autopilot" {
source = "terraform-google-modules/kubernetes-engine/google//modules/beta-autopilot-private-cluster"
version = "~> 40.0"
version = "~> 44.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, the beta-autopilot-private-cluster submodule used on the preceding line is deprecated. Please update it to autopilot-private-cluster to align with the module's latest structure.

Suggestion:
Update line 339 to:

source  = "terraform-google-modules/kubernetes-engine/google//modules/autopilot-private-cluster"


for_each = var.cluster_type == "AUTOPILOT" ? data.google_compute_subnetwork.default : {}
name = "cluster-${each.value.region}-${var.env}"
Expand Down
2 changes: 1 addition & 1 deletion 3-fleetscope/modules/env_baseline/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ resource "google_gke_hub_membership_binding" "membership-binding" {

module "fleet_app_operator_permissions" {
source = "terraform-google-modules/kubernetes-engine/google//modules/fleet-app-operator-permissions"
version = "~> 40.0"
version = "~> 44.0"

for_each = var.namespace_ids

Expand Down