add some parsing options when finding deps#2079
Merged
loosebazooka merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
Contributor
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the cmd_deb_versions function in the knife script by adding support for command-line arguments to filter by architecture, package name, and Debian codename. It also improves error handling for invalid codenames and updates the jq logic to apply these filters. Feedback suggests improving maintainability by using a more general glob pattern for default lock files and refining the output messages for better clarity when filters are applied.
Signed-off-by: Appu <appu@google.com>
loosebazooka
force-pushed
the
update-knife-package-finder
branch
from
64b6dbb to
ee2f8cf
Compare
patflynn
approved these changes
May 8, 2026
Contributor
|
🌳 🔄 Image Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.