Closed
Conversation
Hooking up the changes from kokarare1212/librespot-python#316
|
This would be great |
|
This does not transition to the newly introduced classes, though. What does that mean? |
Owner
This upstream PR does not fully implement lossless streaming. It will likely never be fully implemented, as the original librespot library has said they do not plan to work on the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooking up the changes from
kokarare1212/librespot-python#316
Verification
Completes #72, barring kokarare1212/librespot-python#320.
This does not transition to the newly introduced classes, though.