Skip to content

i18n: add Korean (ko) translation#1408

Open
moduvoice wants to merge 1 commit into
GopeedLab:mainfrom
moduvoice:i18n/add-korean
Open

i18n: add Korean (ko) translation#1408
moduvoice wants to merge 1 commit into
GopeedLab:mainfrom
moduvoice:i18n/add-korean

Conversation

@moduvoice

Copy link
Copy Markdown

Motivation

This adds Korean (ko) translation support — to help Korean-speaking users use this
open-source project more comfortably in their own language.

한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.

Changes

  • Added ui/flutter/lib/i18n/langs/ko_kr.dart with a full Korean (ko_KR) translation map (223 keys).
  • Registered the new locale in ui/flutter/lib/i18n/message.dart (import + spread into the keys map), mirroring exactly how the existing ja_jp locale is registered — no other changes.

Testing

  • Verified ko_kr.dart has exactly the same 223 keys as en_us.dart, in the same order, with no missing/extra/duplicate keys (scripted key-set comparison).
  • Verified every @-prefixed placeholder (@count, @time, @version, @port, @name, @value, @append) is preserved untouched and in the same relative position as in en_us.dart, per the placeholder convention noted in CONTRIBUTING.md.
  • Spot-checked translation naturalness across a random sample plus all placeholder-bearing strings.
  • Note: dart format ./ui/flutter was not run locally (Flutter/Dart toolchain unavailable in this environment). Formatting/line-wrapping was manually matched to en_us.dart's conventions, but please have CI/a reviewer double-check formatting.

Add ko_kr.dart with a full Korean translation of all 223 UI strings,
following the existing GetX-based translation map convention (see
en_us.dart). Register the new locale in message.dart, which is the
single source of truth for both the language switcher dropdown and
MaterialApp's supportedLocales (both derived from messages.keys.keys).
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.69%. Comparing base (c01d113) to head (1aa5bb2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
+ Coverage   68.59%   68.69%   +0.09%     
==========================================
  Files          60       60              
  Lines        9177     9177              
==========================================
+ Hits         6295     6304       +9     
+ Misses       2184     2175       -9     
  Partials      698      698              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants