use of codicon icons where possible#71
Open
GitMensch wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
kindly requesting review from @GorvGoyl |
Owner
|
Thanks, @GitMensch I'm all in for built-in vscode icons. I hope all new icons look similar to the existing ones. Could you also mention the use of built-in icons in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is "kind of" a draft. The main reason is that some symbols don't have an exact or "normal" matching icon, so I've looked up some possible alternatives to look at - and in the end the screenshots should be adjusted before a release can be done.
Reasons why those icons are preferable to the use of own svg files include:
Note: I'm totally aware that when this extension started there was no codicon option to use. But nowadays those code icons are available in even old installations of vscode so I think it is better to use them.