Skip to content

use of codicon icons where possible#71

Open
GitMensch wants to merge 1 commit into
GorvGoyl:masterfrom
GitMensch:master
Open

use of codicon icons where possible#71
GitMensch wants to merge 1 commit into
GorvGoyl:masterfrom
GitMensch:master

Conversation

@GitMensch

Copy link
Copy Markdown
Contributor

This is "kind of" a draft. The main reason is that some symbols don't have an exact or "normal" matching icon, so I've looked up some possible alternatives to look at - and in the end the screenshots should be adjusted before a release can be done.

Reasons why those icons are preferable to the use of own svg files include:

Note: I'm totally aware that when this extension started there was no codicon option to use. But nowadays those code icons are available in even old installations of vscode so I think it is better to use them.

@GitMensch GitMensch marked this pull request as draft January 25, 2022 17:26
@GitMensch

Copy link
Copy Markdown
Contributor Author

kindly requesting review from @GorvGoyl

@GorvGoyl GorvGoyl marked this pull request as ready for review February 13, 2022 12:25
@GorvGoyl

Copy link
Copy Markdown
Owner

Thanks, @GitMensch I'm all in for built-in vscode icons. I hope all new icons look similar to the existing ones. Could you also mention the use of built-in icons in help.md (### Adding new buttons) file so that it's easier for new contributors. Once the PR is merged I'll create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants