Skip to content

Patch itself to use codicons#90

Open
sr-tream wants to merge 1 commit into
GorvGoyl:masterfrom
sr-tream:codicon-in-user-commands
Open

Patch itself to use codicons#90
sr-tream wants to merge 1 commit into
GorvGoyl:masterfrom
sr-tream:codicon-in-user-commands

Conversation

@sr-tream

@sr-tream sr-tream commented Feb 9, 2024

Copy link
Copy Markdown

Allow usage codicons before button command, like that: $(vm-running)cmake.configure.

When used codicon, extension patch self package.json on VSCode startup

@GorvGoyl

Copy link
Copy Markdown
Owner

thanks for submitting the PR. Could you please explain the benefit of this?

@sr-tream

Copy link
Copy Markdown
Author

thanks for submitting the PR. Could you please explain the benefit of this?

Do not require manual patching of extension to use custom icons for user buttons.

With this PR, you can just add codicon before command and restart VSCode (This hack no need now)

@serhumanos

Copy link
Copy Markdown

hi, Will this patch be available in the future? thanks

thexmeta added a commit to thexmeta/Shortcut-Menu-Bar-VSCode-Extension that referenced this pull request Apr 24, 2026
…tion conflicts\n- Migrates extension icons to standard VSCode codicons (GorvGoyl#90)\n- Adds new fold/unfold + PlantUML buttons (GorvGoyl#78)\n- Adds toggle maximize editor group button (GorvGoyl#88)\n- Sets activationEvent properly to onStartupFinished to correctly load up the extension on new versions of VSCode. (#1)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: thexmeta <3031096+thexmeta@users.noreply.github.com>
thexmeta added a commit to thexmeta/Shortcut-Menu-Bar-VSCode-Extension that referenced this pull request Apr 24, 2026
…tion conflicts\n- Migrates extension icons to standard VSCode codicons (GorvGoyl#90)\n- Adds new fold/unfold + PlantUML buttons (GorvGoyl#78)\n- Adds toggle maximize editor group button (GorvGoyl#88)\n- Sets activationEvent properly to onStartupFinished to correctly load up the extension on new versions of VSCode.

Co-authored-by: thexmeta <3031096+thexmeta@users.noreply.github.com>
thexmeta added a commit to thexmeta/Shortcut-Menu-Bar-VSCode-Extension that referenced this pull request Apr 24, 2026
…tion conflicts\n- Migrates extension icons to standard VSCode codicons (GorvGoyl#90)\n- Adds new fold/unfold + PlantUML buttons (GorvGoyl#78)\n- Adds toggle maximize editor group button (GorvGoyl#88)\n- Sets activationEvent properly to onStartupFinished to correctly load up the extension on new versions of VSCode.

Co-authored-by: thexmeta <3031096+thexmeta@users.noreply.github.com>
thexmeta added a commit to thexmeta/Shortcut-Menu-Bar-VSCode-Extension that referenced this pull request Apr 24, 2026
…tion conflicts\n- Migrates extension icons to standard VSCode codicons (GorvGoyl#90)\n- Adds new fold/unfold + PlantUML buttons (GorvGoyl#78)\n- Adds toggle maximize editor group button (GorvGoyl#88)\n- Sets activationEvent properly to onStartupFinished to correctly load up the extension on new versions of VSCode.\n- Bumps version to 3.0.5

Co-authored-by: thexmeta <3031096+thexmeta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants