use +PENDING virtual tag in built-in report filters (#4116)

Author: carmiac

src/Context.cpp

@@ -340,30 +340,30 @@ std::string configurationDefaults =
     "Description\n"
     "report.long.columns=id,start.active,entry,modified.age,depends,priority,project,tags,recur,"
     "wait.remaining,scheduled,due,until,description\n"
-    "report.long.filter=status:pending -WAITING\n"
+    "report.long.filter=+PENDING -WAITING\n"
     "report.long.sort=modified-\n"
     "report.long.context=1\n"
     "\n"
     "report.list.description=Most details of tasks\n"
     "report.list.labels=ID,Active,Age,D,P,Project,Tags,R,Sch,Due,Until,Description,Urg\n"
     "report.list.columns=id,start.age,entry.age,depends.indicator,priority,project,tags,recur."
     "indicator,scheduled.countdown,due,until.remaining,description.count,urgency\n"
-    "report.list.filter=status:pending -WAITING\n"
+    "report.list.filter=+PENDING -WAITING\n"
     "report.list.sort=start-,due+,project+,urgency-\n"
     "report.list.context=1\n"
     "\n"
     "report.ls.description=Few details of tasks\n"
     "report.ls.labels=ID,A,D,Project,Tags,R,Wait,S,Due,Until,Description\n"
     "report.ls.columns=id,start.active,depends.indicator,project,tags,recur.indicator,wait."
     "remaining,scheduled.countdown,due.countdown,until.countdown,description.count\n"
-    "report.ls.filter=status:pending -WAITING\n"
+    "report.ls.filter=+PENDING -WAITING\n"
     "report.ls.sort=start-,description+\n"
     "report.ls.context=1\n"
     "\n"
     "report.minimal.description=Minimal details of tasks\n"
     "report.minimal.labels=ID,Project,Tags,Description\n"
     "report.minimal.columns=id,project,tags.count,description.count\n"
-    "report.minimal.filter=status:pending -WAITING\n"
+    "report.minimal.filter=+PENDING -WAITING\n"
     "report.minimal.sort=project+/,description+\n"
     "report.minimal.context=1\n"
     "\n"
@@ -372,7 +372,7 @@ std::string configurationDefaults =
     "Description\n"
     "report.newest.columns=id,start.age,entry,entry.age,modified.age,depends.indicator,priority,"
     "project,tags,recur.indicator,wait.remaining,scheduled.countdown,due,until.age,description\n"
-    "report.newest.filter=status:pending -WAITING\n"
+    "report.newest.filter=+PENDING -WAITING\n"
     "report.newest.sort=entry-\n"
     "report.newest.context=1\n"
     "\n"
@@ -381,15 +381,15 @@ std::string configurationDefaults =
     "Description\n"
     "report.oldest.columns=id,start.age,entry,entry.age,modified.age,depends.indicator,priority,"
     "project,tags,recur.indicator,wait.remaining,scheduled.countdown,due,until.age,description\n"
-    "report.oldest.filter=status:pending -WAITING\n"
+    "report.oldest.filter=+PENDING -WAITING\n"
     "report.oldest.sort=entry+\n"
     "report.oldest.context=1\n"
     "\n"
     "report.overdue.description=Overdue tasks\n"
     "report.overdue.labels=ID,Active,Age,Deps,P,Project,Tag,R,S,Due,Until,Description,Urg\n"
     "report.overdue.columns=id,start.age,entry.age,depends,priority,project,tags,recur.indicator,"
     "scheduled.countdown,due,until,description,urgency\n"
-    "report.overdue.filter=status:pending -WAITING +OVERDUE\n"
+    "report.overdue.filter=+PENDING -WAITING +OVERDUE\n"
     "report.overdue.sort=urgency-,due+\n"
     "report.overdue.context=1\n"
     "\n"
@@ -398,7 +398,7 @@ std::string configurationDefaults =
     "Description\n"
     "report.active.columns=id,start,start.age,entry.age,depends.indicator,priority,project,tags,"
     "recur,wait,scheduled.remaining,due,until,description\n"
-    "report.active.filter=status:pending -WAITING +ACTIVE\n"
+    "report.active.filter=+PENDING -WAITING +ACTIVE\n"
     "report.active.sort=project+,start+\n"
     "report.active.context=1\n"
     "\n"
@@ -415,7 +415,7 @@ std::string configurationDefaults =
     "Urg\n"
     "report.recurring.columns=id,start.age,entry.age,depends.indicator,priority,parent.short,"
     "project,tags,recur,scheduled.countdown,due,until.remaining,description,urgency\n"
-    "report.recurring.filter=(status:pending -WAITING +CHILD) or (status:recurring -WAITING "
+    "report.recurring.filter=(+PENDING -WAITING +CHILD) or (status:recurring -WAITING "
     "+PARENT)\n"
     "report.recurring.sort=due+,urgency-,entry+\n"
     "report.recurring.context=1\n"
@@ -440,7 +440,7 @@ std::string configurationDefaults =
     "report.next.labels=ID,Active,Age,Deps,P,Project,Tag,Recur,S,Due,Until,Description,Urg\n"
     "report.next.columns=id,start.age,entry.age,depends,priority,project,tags,recur,scheduled."
     "countdown,due.relative,until.remaining,description,urgency\n"
-    "report.next.filter=status:pending -WAITING limit:page\n"
+    "report.next.filter=+PENDING -WAITING limit:page\n"
     "report.next.sort=urgency-\n"
     "report.next.context=1\n"
     "\n"
@@ -456,22 +456,22 @@ std::string configurationDefaults =
     "report.blocked.columns=id,depends,project,priority,due,start.active,entry.age,description\n"
     "report.blocked.labels=ID,Deps,Proj,Pri,Due,Active,Age,Description\n"
     "report.blocked.sort=due+,priority-,start-,project+\n"
-    "report.blocked.filter=status:pending -WAITING +BLOCKED\n"
+    "report.blocked.filter=+PENDING -WAITING +BLOCKED\n"
     "report.blocked.context=1\n"
     "\n"
     "report.unblocked.description=Unblocked tasks\n"
     "report.unblocked.columns=id,depends,project,priority,due,start.active,entry.age,description\n"
     "report.unblocked.labels=ID,Deps,Proj,Pri,Due,Active,Age,Description\n"
     "report.unblocked.sort=due+,priority-,start-,project+\n"
-    "report.unblocked.filter=status:pending -WAITING -BLOCKED\n"
+    "report.unblocked.filter=+PENDING -WAITING -BLOCKED\n"
     "report.unblocked.context=1\n"
     "\n"
     "report.blocking.description=Blocking tasks\n"
     "report.blocking.labels=ID,UUID,A,Deps,Project,Tags,R,W,Sch,Due,Until,Description,Urg\n"
     "report.blocking.columns=id,uuid.short,start.active,depends,project,tags,recur,wait,scheduled."
     "remaining,due.relative,until.remaining,description.count,urgency\n"
     "report.blocking.sort=urgency-,due+,entry+\n"
-    "report.blocking.filter=status:pending -WAITING +BLOCKING\n"
+    "report.blocking.filter=+PENDING -WAITING +BLOCKING\n"
     "report.blocking.context=1\n"
     "\n"
     "report.timesheet.filter=(+PENDING -WAITING start.after:now-4wks) or (+COMPLETED -WAITING "