Skip to content

Commit 662c1bd

Browse files
chore(helm): revert opinionated default values to upstream-friendly defaults
Earlier additions baked GovSignals-specific worker SA defaults into the chart's values.yaml. That makes the chart less mergeable upstream — it silently changes default behavior for every consumer. Revert to neutral defaults so this PR is purely additive (new knobs, off by default): supervisor.config.kubernetes.workerServiceAccount: "trigger-worker" -> "" supervisor.config.kubernetes.workerAutomountServiceAccountToken: true -> false worker.serviceAccount.create: true -> false worker.serviceAccount.name: "trigger-worker" -> "" Comment-only fix: clickhouse example image reference rolled back from 25.6.1-debian-12-r0 to upstream's 25.7.5-debian-12-r0 (stale rebase artifact). Consumers who want the previous defaults set them explicitly. The GovSignals umbrella will set these in its own values.yaml. Result: 106 lines changed vs upstream main, all pure additions of new knobs (extraContainers, extraInitContainers, initContainers/ sidecarContainers securityContext, supervisor.extraVolumes/ extraVolumeMounts, worker.serviceAccount, worker.rbac). Each new knob has an empty/zero default, so chart behavior for default users is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 2cad48b commit 662c1bd

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

hosting/k8s/helm/values.yaml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,8 @@ supervisor:
329329
forceEnabled: true
330330
namespace: "" # Default: uses release namespace
331331
workerNodetypeLabel: "" # When set, runs will only be scheduled on nodes with "nodetype=<label>"
332-
workerServiceAccount: "trigger-worker" # Service account name for worker pods (e.g. "trigger-worker")
333-
workerAutomountServiceAccountToken: true # Whether to mount the SA token in worker pods. Keep false unless pods need K8s API access
332+
workerServiceAccount: "" # Service account name for worker pods. Empty = use namespace's "default" SA. Set to e.g. "trigger-worker" to pin a dedicated SA.
333+
workerAutomountServiceAccountToken: false # Whether to mount the SA token in worker pods. Keep false unless pods need K8s API access.
334334
ephemeralStorageSizeLimit: "" # Default: 10Gi
335335
ephemeralStorageSizeRequest: "" # Default: 2Gi´
336336
podCleaner:
@@ -464,10 +464,13 @@ supervisor:
464464

465465
# Worker pod configuration
466466
worker:
467-
# Service account for worker pods
467+
# Service account for worker pods. Off by default — most setups can use
468+
# the namespace's "default" SA, or set `supervisor.config.kubernetes.
469+
# workerServiceAccount` to point at an externally-managed SA. Set
470+
# `create: true` and pick a name to have the chart provision one.
468471
serviceAccount:
469-
create: true # Set to true to create a service account for worker pods
470-
name: "trigger-worker" # Name of the service account
472+
create: false # Set to true to create a service account for worker pods
473+
name: "" # Name of the service account (only used when create: true)
471474
annotations: {} # Annotations to add to the service account (e.g., for AWS IRSA, GCP Workload Identity)
472475

473476
# RBAC configuration for worker pods.
@@ -645,7 +648,7 @@ clickhouse:
645648
image:
646649
# Use bitnami legacy repo
647650
repository: bitnamilegacy/clickhouse
648-
# image: docker.io/bitnamilegacy/clickhouse:25.6.1-debian-12-r0
651+
# image: docker.io/bitnamilegacy/clickhouse:25.7.5-debian-12-r0
649652

650653
# TLS/Secure connection configuration
651654
secure: false # Set to true to use HTTPS and secure connections

0 commit comments

Comments
 (0)