Skip to content

Commit 8ab0a67

Browse files
fix(chart/webapp): render webapp.service.annotations on the Service object (PLT-900)
The upstream chart's webapp Service template renders `labels` but never renders `annotations` from `webapp.service.annotations`. That makes the value silently inert, blocking platforms (e.g. Palantir Rubix on FedStart) that mint per-Service TLS certs from a Service annotation — `com.palantir.rubix.service/pod-cert: "{}"` would have no effect, so `cert-<fullname>-webapp` never gets minted and the nginx-tls sidecar fails to mount it. Add the standard `{{- with .Values.webapp.service.annotations }}` block on the webapp Service, mirroring how every other Service template in this chart (electric, supervisor, the bitnami subcharts) already exposes `service.annotations`. Default to `{}` in values.yaml so the field is discoverable. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 63f1f83 commit 8ab0a67

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

hosting/k8s/helm/templates/webapp.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,10 @@ metadata:
490490
labels:
491491
{{- $component := "webapp" }}
492492
{{- include "trigger-v4.componentLabels" (dict "Chart" .Chart "Release" .Release "Values" .Values "component" $component) | nindent 4 }}
493+
{{- with .Values.webapp.service.annotations }}
494+
annotations:
495+
{{- toYaml . | nindent 4 }}
496+
{{- end }}
493497
spec:
494498
type: {{ .Values.webapp.service.type }}
495499
ports:

hosting/k8s/helm/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -577,6 +577,7 @@ electric:
577577
type: ClusterIP
578578
port: 3000
579579
targetPort: 3000
580+
annotations: {}
580581
resources: {}
581582

582583
# Health probe configuration

0 commit comments

Comments
 (0)