Skip to content

Commit b58619b

Browse files
e2e testing
1 parent b1f4fc9 commit b58619b

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

packages/cli-v3/src/commands/deploy.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,6 +1837,7 @@ async function registerOnlyDeploy(projectPath: string, dir: string, options: Dep
18371837
gitMeta,
18381838
type: deployData.buildManifest.features?.run_engine_v2 ? "MANAGED" : "V1",
18391839
runtime: deployData.runtime,
1840+
isNativeBuild: false,
18401841
});
18411842

18421843
if (!deploymentResponse.success) {

packages/cli-v3/src/deploy/buildImage.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export interface BuildImageOptions {
4848
extraCACerts?: string;
4949
apiUrl: string;
5050
apiKey: string;
51-
apiClient: CliApiClient;
51+
apiClient?: CliApiClient;
5252
branchName?: string;
5353
buildEnvVars?: Record<string, string | undefined>;
5454
indexEnvVars?: Record<string, string>; // Environment variables for indexing
@@ -346,7 +346,7 @@ interface SelfHostedBuildImageOptions {
346346
authenticateToRegistry?: boolean;
347347
apiUrl: string;
348348
apiKey: string;
349-
apiClient: CliApiClient;
349+
apiClient?: CliApiClient;
350350
branchName?: string;
351351
noCache?: boolean;
352352
useRegistryCache?: boolean;
@@ -499,6 +499,14 @@ async function localBuildImage(options: SelfHostedBuildImageOptions): Promise<Bu
499499
};
500500
}
501501

502+
if (!apiClient) {
503+
return {
504+
ok: false as const,
505+
error: "API client is required for registry authentication",
506+
logs: "",
507+
};
508+
}
509+
502510
const [credentialsError, credentials] = await tryCatch(
503511
getDockerUsernameAndPassword(apiClient, deploymentId)
504512
);

references/hello-world/trigger.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { lightpanda } from "@trigger.dev/build/extensions/lightpanda";
44

55
export default defineConfig({
66
compatibilityFlags: ["run_engine_v2"],
7-
project: "proj_rrkpdguyagvsoktglnod",
7+
project: "proj_vaegotxxglociskxdzmf",
88
experimental_processKeepAlive: {
99
enabled: true,
1010
maxExecutionsPerProcess: 20,

0 commit comments

Comments
 (0)