Commit e8ad21c
fix(chart/webapp): introduce separate webapp.service.servicePortTargetPort knob
PLT-906's previous patch overloaded webapp.service.targetPort for two
different purposes: (1) the webapp container's listening port (used
by .containerPort on the Deployment AND by downstream consumers like
sidecar nginx proxy_pass localhost:<port>), and (2) the Service's
ports[].targetPort field that controls in-pod routing.
Those two values diverge whenever the Service should route through a
sidecar container's named port (e.g. an in-pod TLS terminator or auth
proxy) rather than directly to the webapp container. Overloading one
field forced consumers to pick between routing through the sidecar
and being able to reach the webapp.
Add a dedicated webapp.service.servicePortTargetPort knob (default
empty -> falls back to webapp.service.targetPort -> 'http'), so
deployments can route Service traffic to a sidecar's named port
without affecting containerPort / downstream consumers. Existing
behavior preserved for users who don't set the new knob.
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent 3ddd2b9 commit e8ad21c
3 files changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
498 | 498 | | |
499 | 499 | | |
500 | 500 | | |
501 | | - | |
| 501 | + | |
502 | 502 | | |
503 | 503 | | |
504 | 504 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
581 | 581 | | |
582 | 582 | | |
583 | 583 | | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
584 | 593 | | |
585 | 594 | | |
586 | 595 | | |
| |||
0 commit comments