Stop using start script templates bundled in Shadow (#1750)

* Remove `unixStartScriptGenerator` and `windowsStartScriptGenerator` overrides

* Update changelog

* Fix tests

Author: Goooler

src/docs/changes/README.md

@@ -3,6 +3,10 @@
 
 ## [Unreleased]
 
+**Changed**
+
+- Stop using start script templates bundled in Shadow. ([#1750](https://github.com/GradleUp/shadow/pull/1750))
+
 **Fixed**
 
 - Fix resolving BOM dependencies when `minimize` is enabled. ([#1638](https://github.com/GradleUp/shadow/pull/1638))

src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.groovy

@@ -79,8 +79,6 @@ class ShadowApplicationPlugin implements Plugin<Project> {
 
     protected void addCreateScriptsTask(Project project) {
         project.tasks.register(SHADOW_SCRIPTS_TASK_NAME, CreateStartScripts) { startScripts ->
-            startScripts.unixStartScriptGenerator.template = project.resources.text.fromString(this.class.getResource("internal/unixStartScript.txt").text)
-            startScripts.windowsStartScriptGenerator.template = project.resources.text.fromString(this.class.getResource("internal/windowsStartScript.txt").text)
             startScripts.description = 'Creates OS specific scripts to run the project as a JVM application using the shadow jar'
             startScripts.group = ApplicationPlugin.APPLICATION_GROUP
             startScripts.classpath = project.files(jar)

src/main/resources/com/github/jengelman/gradle/plugins/shadow/internal/unixStartScript.txt

@@ -66,7 +66,6 @@ class ApplicationSpec extends PluginSpecification {
         File startScript = getFile('build/install/myapp-shadow/bin/myapp')
         assert startScript.exists()
         assert startScript.text.contains("CLASSPATH=\$APP_HOME/lib/myapp-1.0-all.jar")
-        assert startScript.text.contains("-jar \"\\\"\$CLASSPATH\\\"\" \"\$APP_ARGS\"")
         assert startScript.text.contains("exec \"\$JAVACMD\" \"\$@\"")
 
         cleanup:
@@ -146,7 +145,6 @@ class ApplicationSpec extends PluginSpecification {
         File startScript = getFile('build/install/myapp-shadow/bin/myapp')
         assert startScript.exists()
         assert startScript.text.contains("CLASSPATH=\$APP_HOME/lib/myapp-1.0-all.jar")
-        assert startScript.text.contains("-jar \"\\\"\$CLASSPATH\\\"\" \"\$APP_ARGS\"")
         assert startScript.text.contains("exec \"\$JAVACMD\" \"\$@\"")
 
         cleanup: