fix: remove errors array, add onError closure to ValidationContext

Author: jsinnerpl

Sources/GraphQL/Validation/Validate.swift

@@ -50,14 +50,15 @@ func visit(
     typeInfo: TypeInfo,
     documentAST: Document
 ) -> [GraphQLError] {
-    let context = ValidationContext(schema: schema, ast: documentAST, typeInfo: typeInfo)
+    var errors = [GraphQLError]()
+    let context = ValidationContext(schema: schema, ast: documentAST, typeInfo: typeInfo, onError: { errors.append($0) })
     let visitors = rules.map { rule in rule(context) }
     // Visit the whole document with each instance of all provided rules.
     visit(
         root: documentAST,
         visitor: visitWithTypeInfo(typeInfo: typeInfo, visitor: visitInParallel(visitors: visitors))
     )
-    return context.errors
+    return errors
 }
 
 /// Utility function which asserts a SDL document is valid by throwing an error

Sources/GraphQL/Validation/ValidationContext.swift

@@ -164,22 +164,16 @@ public typealias SDLValidationRule = @Sendable (SDLValidationContext) -> Visitor
 public final class ValidationContext: ASTValidationContext {
     public let schema: GraphQLSchema
     let typeInfo: TypeInfo
-    var errors: [GraphQLError]
     var variableUsages: [HasSelectionSet: [VariableUsage]]
     var recursiveVariableUsages: [OperationDefinition: [VariableUsage]]
 
-    init(schema: GraphQLSchema, ast: Document, typeInfo: TypeInfo) {
+    init(schema: GraphQLSchema, ast: Document, typeInfo: TypeInfo, onError: @escaping (GraphQLError) -> Void) {
         self.schema = schema
         self.typeInfo = typeInfo
-        errors = []
         variableUsages = [:]
         recursiveVariableUsages = [:]
 
-        super.init(ast: ast) { _ in }
-    }
-
-    public override func report(error: GraphQLError) {
-        errors.append(error)
+        super.init(ast: ast, onError: onError) 
     }
 
     func getSchema() -> GraphQLSchema? {