feat!: Messenger uses Data

Author: NeedleInAJayStack

Sources/GraphQLTransportWS/Messenger.swift

@@ -4,7 +4,7 @@ import Foundation
 public protocol Messenger: Sendable {
     /// Send a message through this messenger
     /// - Parameter message: The message to send
-    func send<S: Sendable & Collection>(_ message: S) async throws where S.Element == Character
+    func send(_ message: Data) async throws
 
     /// Close the messenger
     func close() async throws
@@ -15,15 +15,3 @@ public protocol Messenger: Sendable {
     ///   - code: An error code
     func error(_ message: String, code: Int) async throws
 }
-
-extension Messenger {
-    /// Send a message through this messenger
-    /// - Parameter message: The message to send
-    func send(_ message: Data) async throws {
-        // TODO: Ideally Data is our native interface, and String is the extension.
-        // Since that change is breaking, we will do it on the next major version.
-        if let string = String(data: message, encoding: .utf8) {
-            try await send(string)
-        }
-    }
-}

Tests/GraphQLTransportWSTests/Utils/TestMessenger.swift

@@ -14,10 +14,8 @@ actor TestMessenger: Messenger {
         self.continuation = continuation
     }
 
-    func send<S: Sendable & Collection>(_ message: S) async throws where S.Element == Character {
-        if let data = String(message).data(using: .utf8) {
-            continuation.yield(data)
-        }
+    func send(_ message: Data) async throws {
+        continuation.yield(message)
     }
 
     func error(_ message: String, code: Int) async throws {