add hold shutter to record video in photo mode#655
Open
KonTy wants to merge 1 commit into
Open
Conversation
Press and hold the shutter button or a volume key while in photo mode to record a video, and release to stop. A short tap still takes a photo. Audio is always captured for these clips and the existing recording UI is reused. The behavior can be turned off from a new toggle in More settings and defaults to on. The quick video state machine is kept in a small QuickVideoController so the changes to MainActivity stay minimal, and the on-screen button and the volume keys share the same code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Samsung-style quick video capture in photo mode. Press and hold the shutter button or a volume key to start recording, and release to stop. A short tap still takes a photo as before. Audio is always captured for these clips and the existing recording timer and button are reused. It can be turned off from a new toggle in More settings and is on by default.
The quick video logic lives in a small QuickVideoController so the changes to MainActivity stay minimal, and the on-screen button and the volume keys go through the same path.
This was developed with LLM assistance and extensively tested by Konty on a Galaxy A26 and a Pixel 8a.