Bump eslint from 9.39.4 to 10.4.0

[ggtlvkma356]

Supersede #638, #656.

Dependencies to @eslint/js was removed from eslint. See eslint/eslint#20539.

[inthewaves]

We should update README.md as it says Node.js 20+, but they removed support for Node.js < v20.19: https://eslint.org/docs/latest/use/migrate-to-10.0.0#drop-old-node

ESLint is officially dropping support for these versions of Node.js starting with ESLint v10.0.0. ESLint now supports the following versions of Node.js:

• Node.js v20.19.0 and above
• Node.js v22.13.0 and above
• Node.js v24 and above

To address: Make sure you upgrade to at least Node.js v20.19.0 when using ESLint v10.0.0.

[inthewaves]

Actually pdfjs seems to want higher Node.js too (though haven't seen issues)l, this is from the CI run

> Task :app:npmSetup
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'pdfjs-dist@5.7.284',
npm warn EBADENGINE   required: { node: '>=22.13.0 || >=24' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }

[ggtlvkma356]

Actually pdfjs seems to want higher Node.js too (though haven't seen issues)l, this is from the CI run

> Task :app:npmSetup
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'pdfjs-dist@5.7.284',
npm warn EBADENGINE   required: { node: '>=22.13.0 || >=24' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }

That is likely because of the default version used by setup-node. I can change the workflow to use a higher version.

[ggtlvkma356]

I have made CI use node 22. Also upgraded eslint to 10.4.0, which doesn't have extra changes needed.

[inthewaves]

Passed and works locally

[ggtlvkma356]

Updated to latest main.

[thestinger]

@ggtlvkma356 Can you split the Node.js version change into a separate commit? The eslint updates could also be merged into 1 commit.

[thestinger]

There should probably just be 1 commit updating eslint which fixes the issue. Can just drop the dependabot commit.

[ggtlvkma356]

@thestinger Ok I have updated with 1 commit for updating the eslint version and 1 commit for updating node version.

[thestinger]

@ggtlvkma356 Could we use Node.js 24 instead of 22?

[thestinger]

10.4.1 was released so I squashed that into it.

[ggtlvkma356]

@thestinger I tested node 24 locally and it builds and tests fine. Since it is mainly used to run the build script I think it is fine to update.

[thestinger]

@ggtlvkma356 Okay, I just modified the existing commit to keep the history clean.