ci: add Zizmor workflow and apply recommendations#282
Open
HastD wants to merge 1 commit intoGrapheneOS:mainfrom
Open
ci: add Zizmor workflow and apply recommendations#282HastD wants to merge 1 commit intoGrapheneOS:mainfrom
HastD wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
Add a workflow that runs Zizmor, a static analysis tool for GitHub Actions, on pushes to main and PRs. Also apply Zizmor's recommendations: * Add cooldown timer for Dependabot updates. * Deny unnecessary permissions to workflows. * Add concurrency limits to cancel redundant workflow runs. * Pin `actions/checkout` to the latest commit hash. * Set `persist-credentials: false` for `actions/checkout`. * Replace template expansions with environment variables in code contexts. * Pin Alpine container image to non-`latest` tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a workflow that runs Zizmor, a static analysis tool for GitHub Actions, on pushes to main and PRs. Also apply Zizmor's recommendations:
actions/checkoutto the latest commit hash.persist-credentials: falseforactions/checkout.latesttag.Given the relatively simple nature of the existing CI jobs, it seems unlikely that any of the above issues represents an actual vulnerability in the workflow. Nonetheless, this reflects best practices for GitHub Actions and reduces the risk of a vulnerability being introduced in the future if additional CI workflows were to be added.