Code review simplification

Keavon · Keavon · commit 131ff8ce8bc2 · 2026-03-28T20:11:04.000-07:00
diff --git a/node-graph/libraries/core-types/src/transform.rs b/node-graph/libraries/core-types/src/transform.rs
@@ -44,7 +44,7 @@ pub trait Transform {
 
 		let scale_x = if cos.abs() > 1e-10 { x_axis.x / cos } else { x_axis.y / sin };
 
-		let mut skew = (sin * y_axis.y + cos * y_axis.x) / (sin * sin * scale_x + cos * cos * scale_x);
+		let mut skew = (sin * y_axis.y + cos * y_axis.x) / scale_x;
 		if !skew.is_finite() {
 			skew = 0.;
 		}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ pub trait Transform {`
`44`	`44`
`45`	`45`	`let scale_x = if cos.abs() > 1e-10 { x_axis.x / cos } else { x_axis.y / sin };`
`46`	`46`
`47`		`- let mut skew = (sin * y_axis.y + cos * y_axis.x) / (sin * sin * scale_x + cos * cos * scale_x);`
	`47`	`+ let mut skew = (sin * y_axis.y + cos * y_axis.x) / scale_x;`
`48`	`48`	`if !skew.is_finite() {`
`49`	`49`	`skew = 0.;`
`50`	`50`	`}`