Review

Author: timon-schelling

desktop/src/lib.rs

@@ -169,6 +169,5 @@ pub fn start() -> ExitCode {
 		_ => {}
 	}
 
-	#[cfg(not(target_os = "windows"))]
 	ExitCode::SUCCESS
 }

desktop/ui/src/frames/import.rs

@@ -15,9 +15,11 @@ pub(crate) enum TextureImportError {
 	InvalidHandle(String),
 	#[error("Unsupported texture format: {format:?}")]
 	UnsupportedFormat { format: cef_color_type_t },
+	#[cfg(not(target_os = "macos"))]
 	#[error("Hardware acceleration not available: {reason}")]
 	HardwareUnavailable { reason: String },
 	#[error("Vulkan operation failed: {operation}")]
+	#[cfg(target_os = "linux")]
 	VulkanError { operation: String },
 	#[error("Platform-specific error: {message}")]
 	PlatformError { message: String },

desktop/ui/src/remote/spawn.rs

@@ -23,7 +23,7 @@ pub(crate) struct HostHandle {
 	child: Arc<Mutex<Child>>,
 	shutting_down: Arc<AtomicBool>,
 	died_reported: Arc<AtomicBool>,
-	#[cfg_attr(not(feature = "accelerated_paint"), expect(dead_code))]
+	#[cfg_attr(any(not(feature = "accelerated_paint"), target_os = "windows"), expect(dead_code))]
 	host_acceleration: bool,
 	#[cfg(target_os = "windows")]
 	_job: Option<platform::win::KillOnCloseJob>,