Rename cases where "shear" terminology was used in place of "skew"

Author: Keavon

editor/src/messages/portfolio/document/graph_operation/transform_utils.rs

@@ -12,12 +12,12 @@ pub fn update_transform(network_interface: &mut NodeNetworkInterface, node_id: &
 	let translation = transform.translation;
 
 	let rotation = rotation.to_degrees();
-	let shear = DVec2::new(skew.atan().to_degrees(), 0.);
+	let skew = DVec2::new(skew.atan().to_degrees(), 0.);
 
 	network_interface.set_input(&InputConnector::node(*node_id, 1), NodeInput::value(TaggedValue::DVec2(translation), false), &[]);
 	network_interface.set_input(&InputConnector::node(*node_id, 2), NodeInput::value(TaggedValue::F64(rotation), false), &[]);
 	network_interface.set_input(&InputConnector::node(*node_id, 3), NodeInput::value(TaggedValue::DVec2(scale), false), &[]);
-	network_interface.set_input(&InputConnector::node(*node_id, 4), NodeInput::value(TaggedValue::DVec2(shear), false), &[]);
+	network_interface.set_input(&InputConnector::node(*node_id, 4), NodeInput::value(TaggedValue::DVec2(skew), false), &[]);
 }
 
 // TODO: This should be extracted from the graph at the location of the transform node.
@@ -58,12 +58,12 @@ pub fn get_current_transform(inputs: &[NodeInput]) -> DAffine2 {
 	};
 	let rotation = if let Some(&TaggedValue::F64(rotation)) = inputs[2].as_value() { rotation } else { 0. };
 	let scale = if let Some(&TaggedValue::DVec2(scale)) = inputs[3].as_value() { scale } else { DVec2::ONE };
-	let shear = if let Some(&TaggedValue::DVec2(shear)) = inputs[4].as_value() { shear } else { DVec2::ZERO };
+	let skew = if let Some(&TaggedValue::DVec2(skew)) = inputs[4].as_value() { skew } else { DVec2::ZERO };
 
 	let rotation = rotation.to_radians();
-	let shear = DVec2::new(shear.x.to_radians().tan(), shear.y.to_radians().tan());
+	let skew = DVec2::new(skew.x.to_radians().tan(), skew.y.to_radians().tan());
 
-	DAffine2::from_scale_angle_translation(scale, rotation, translation) * DAffine2::from_cols_array(&[1., shear.y, shear.x, 1., 0., 0.])
+	DAffine2::from_scale_angle_translation(scale, rotation, translation) * DAffine2::from_cols_array(&[1., skew.y, skew.x, 1., 0., 0.])
 }
 
 /// Extract the current normalized pivot from the layer
@@ -112,22 +112,22 @@ mod tests {
 	/// ```
 	#[test]
 	fn derive_transform() {
-		for shear_x in -10..=10 {
-			let shear_x = (shear_x as f64) / 2.;
+		for skew_x in -10..=10 {
+			let skew_x = (skew_x as f64) / 2.;
 			for angle in (0..=360).step_by(15) {
 				let angle = (angle as f64).to_radians();
 				for scale_x in 1..10 {
 					let scale_x = (scale_x as f64) / 5.;
 					for scale_y in 1..10 {
 						let scale_y = (scale_y as f64) / 5.;
 
-						let shear = DVec2::new(shear_x, 0.);
+						let skew = DVec2::new(skew_x, 0.);
 						let scale = DVec2::new(scale_x, scale_y);
 						let translate = DVec2::new(5666., 644.);
 
 						let original_transform = DAffine2::from_cols(
-							DVec2::new(scale.x * angle.cos() - scale.y * angle.sin() * shear.y, scale.x * angle.sin() + scale.y * angle.cos() * shear.y),
-							DVec2::new(scale.x * angle.cos() * shear.x - scale.y * angle.sin(), scale.x * angle.sin() * shear.x + scale.y * angle.cos()),
+							DVec2::new(scale.x * angle.cos() - scale.y * angle.sin() * skew.y, scale.x * angle.sin() + scale.y * angle.cos() * skew.y),
+							DVec2::new(scale.x * angle.cos() * skew.x - scale.y * angle.sin(), scale.x * angle.sin() * skew.x + scale.y * angle.cos()),
 							translate,
 						);
 
@@ -137,7 +137,7 @@ mod tests {
 
 						assert!(
 							new_transform.abs_diff_eq(original_transform, 1e-10),
-							"original_transform {original_transform} new_transform {new_transform} / scale {scale} new_scale {new_scale} / angle {angle} new_angle {new_angle} / shear {shear} / new_shear {new_shear}",
+							"original_transform {original_transform} new_transform {new_transform} / scale {scale} new_scale {new_scale} / angle {angle} new_angle {new_angle} / skew {skew} / new_skew {new_skew}",
 						);
 					}
 				}