Skip to content

Commit 3a18737

Browse files
committed
Update the order of the inputs to Blend Shapes for consistency with Morph
1 parent 862811b commit 3a18737

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,9 @@ impl MessageHandler<GraphOperationMessage, GraphOperationMessageContext<'_>> for
188188
network_interface.move_layer_to_stack(layer, parent, insert_index, &[]);
189189
network_interface.move_layer_to_stack(blend_path_layer, parent, insert_index + 1, &[]);
190190

191-
// Connect the Path node's output to the Blend Shapes node's Path parameter input (input 2).
191+
// Connect the Path node's output to the Blend Shapes node's Path parameter input (input 4).
192192
// Done after move_layer_to_stack so chain nodes have correct positions when converted to absolute.
193-
network_interface.set_input(&InputConnector::node(blend_shapes_node_id, 2), NodeInput::node(path_node_id, 0), &[]);
193+
network_interface.set_input(&InputConnector::node(blend_shapes_node_id, 4), NodeInput::node(path_node_id, 0), &[]);
194194

195195
responses.add(NodeGraphMessage::SetDisplayNameImpl {
196196
node_id: id,

editor/src/messages/portfolio/document/graph_operation/utility_types.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,6 @@ impl<'a> ModifyInputsContext<'a> {
159159
pub fn insert_blend_shapes_data(&mut self, layer: LayerNodeIdentifier, count: f64) -> NodeId {
160160
let blend_shapes = resolve_network_node_type("Blend Shapes").expect("Blend Shapes node does not exist").node_template_input_override([
161161
Some(NodeInput::value(TaggedValue::Graphic(Default::default()), true)),
162-
None,
163-
None,
164162
Some(NodeInput::value(TaggedValue::F64(count), false)),
165163
]);
166164

editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ fn document_node_definitions() -> HashMap<DefinitionIdentifier, DocumentNodeDefi
472472
// 0: Separate Subpaths (split path into individual subpaths)
473473
DocumentNode {
474474
implementation: DocumentNodeImplementation::ProtoNode(vector::separate_subpaths::IDENTIFIER),
475-
inputs: vec![NodeInput::import(generic!(T), 2)],
475+
inputs: vec![NodeInput::import(generic!(T), 4)],
476476
..Default::default()
477477
},
478478
// 1: Count Elements (number of subpaths)
@@ -490,7 +490,7 @@ fn document_node_definitions() -> HashMap<DefinitionIdentifier, DocumentNodeDefi
490490
// 3: Floor (integer count per subpath)
491491
DocumentNode {
492492
implementation: DocumentNodeImplementation::ProtoNode(math_nodes::floor::IDENTIFIER),
493-
inputs: vec![NodeInput::import(concrete!(f64), 3)],
493+
inputs: vec![NodeInput::import(concrete!(f64), 1)],
494494
..Default::default()
495495
},
496496
// 4: Multiply (total_instances = count × subpath_count)
@@ -532,7 +532,7 @@ fn document_node_definitions() -> HashMap<DefinitionIdentifier, DocumentNodeDefi
532532
// 10: Path Is Closed (check if current subpath is closed)
533533
DocumentNode {
534534
implementation: DocumentNodeImplementation::ProtoNode(vector::path_is_closed::IDENTIFIER),
535-
inputs: vec![NodeInput::import(generic!(T), 2), NodeInput::node(NodeId(8), 0)],
535+
inputs: vec![NodeInput::import(generic!(T), 4), NodeInput::node(NodeId(8), 0)],
536536
..Default::default()
537537
},
538538
// 11: Switch (closed → count, open → count - 1 as denominator)
@@ -566,15 +566,15 @@ fn document_node_definitions() -> HashMap<DefinitionIdentifier, DocumentNodeDefi
566566
NodeInput::import(generic!(T), 0),
567567
NodeInput::node(NodeId(14), 0),
568568
NodeInput::value(TaggedValue::Bool(false), false),
569-
NodeInput::import(concrete!(vector::misc::InterpolationDistribution), 1),
570-
NodeInput::import(generic!(T), 2),
569+
NodeInput::import(concrete!(vector::misc::InterpolationDistribution), 3),
570+
NodeInput::import(generic!(T), 4),
571571
],
572572
..Default::default()
573573
},
574574
// 16: Repeat
575575
DocumentNode {
576576
implementation: DocumentNodeImplementation::ProtoNode(repeat_nodes::repeat::IDENTIFIER),
577-
inputs: vec![NodeInput::node(NodeId(15), 0), NodeInput::node(NodeId(4), 0), NodeInput::import(generic!(T), 4)],
577+
inputs: vec![NodeInput::node(NodeId(15), 0), NodeInput::node(NodeId(4), 0), NodeInput::import(generic!(T), 2)],
578578
..Default::default()
579579
},
580580
// 17: Max (clamp count to at least 1)
@@ -592,20 +592,20 @@ fn document_node_definitions() -> HashMap<DefinitionIdentifier, DocumentNodeDefi
592592
}),
593593
inputs: vec![
594594
NodeInput::value(TaggedValue::Vector(Default::default()), true),
595-
NodeInput::value(TaggedValue::InterpolationDistribution(Default::default()), false),
596-
NodeInput::value(TaggedValue::Vector(Default::default()), false),
597595
NodeInput::value(TaggedValue::F64(10.), false),
598596
NodeInput::value(TaggedValue::Bool(Default::default()), false),
597+
NodeInput::value(TaggedValue::InterpolationDistribution(Default::default()), false),
598+
NodeInput::value(TaggedValue::Vector(Default::default()), false),
599599
],
600600
..Default::default()
601601
},
602602
persistent_node_metadata: DocumentNodePersistentMetadata {
603603
input_metadata: vec![
604604
("Content", "TODO").into(),
605-
("Distribution", "TODO").into(),
606-
("Path", "TODO").into(),
607605
("Count", "TODO").into(),
608606
("Reverse", "TODO").into(),
607+
("Distribution", "TODO").into(),
608+
("Path", "TODO").into(),
609609
],
610610
output_names: vec!["Out".to_string()],
611611
node_type_metadata: NodeTypePersistentMetadata::node(IVec2::new(0, 0)),

0 commit comments

Comments
 (0)