Skip to content

Commit 3a3f02a

Browse files
committed
fix: unused parameter prefix and added new_size != 0 guard
1 parent 60a4b7b commit 3a3f02a

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

node-graph/libraries/rendering/src/render_ext.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ impl RenderExt for Stroke {
9797
type Output = String;
9898

9999
/// Provide the SVG attributes for the stroke.
100-
fn render(&self, svg_defs: &mut String, element_transform: DAffine2, stroke_transform: DAffine2, bounds: DAffine2, _transformed_bounds: DAffine2, render_params: &RenderParams) -> Self::Output {
100+
fn render(&self, svg_defs: &mut String, element_transform: DAffine2, stroke_transform: DAffine2, bounds: DAffine2, transformed_bounds: DAffine2, render_params: &RenderParams) -> Self::Output {
101101
if !self.has_renderable_stroke() {
102102
return String::new();
103103
}
@@ -123,7 +123,7 @@ impl RenderExt for Stroke {
123123
result
124124
}
125125
Fill::Gradient(gradient) => {
126-
let gradient_id = gradient.render(svg_defs, element_transform, stroke_transform, bounds, _transformed_bounds, render_params);
126+
let gradient_id = gradient.render(svg_defs, element_transform, stroke_transform, bounds, transformed_bounds, render_params);
127127
format!(r##" stroke="url('#{gradient_id}')""##)
128128
}
129129
};

node-graph/nodes/vector/src/vector_nodes.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,11 +1245,14 @@ async fn solidify_stroke(_: impl Ctx, content: Table<Vector>) -> Table<Vector> {
12451245
let old_size = old_bounds[1] - old_bounds[0];
12461246
let new_size = new_bounds[1] - new_bounds[0];
12471247

1248-
// Transform: old_bounds normalized → world → new_bounds normalized
1249-
// point_world = old_bounds[0] + point_normalized * old_size
1250-
// point_new_normalized = (point_world - new_bounds[0]) / new_size
1251-
gradient.start = (old_bounds[0] + gradient.start * old_size - new_bounds[0]) / new_size;
1252-
gradient.end = (old_bounds[0] + gradient.end * old_size - new_bounds[0]) / new_size;
1248+
// Only remap if new_size is non-zero to avoid division by zero
1249+
if new_size != 0. {
1250+
// Transform: old_bounds normalized → world → new_bounds normalized
1251+
// point_world = old_bounds[0] + point_normalized * old_size
1252+
// point_new_normalized = (point_world - new_bounds[0]) / new_size
1253+
gradient.start = (old_bounds[0] + gradient.start * old_size - new_bounds[0]) / new_size;
1254+
gradient.end = (old_bounds[0] + gradient.end * old_size - new_bounds[0]) / new_size;
1255+
}
12531256
}
12541257

12551258
result.style.set_fill(paint);

0 commit comments

Comments
 (0)