Reduce development environment warnings and remove DWARF debug symbols (#2741)

* Ignore tauri gen

* Deny warnings on CI

* Fix all warnings in current nightly rustc

* Disable DWARF debug info for development builds

* Fix typo

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>

Author: 0HyperCube

.github/workflows/build-dev-and-ci.yml

@@ -84,6 +84,8 @@ jobs:
           mold -run cargo fmt --all -- --check
 
       - name: 🦀 Build Rust code
+        env:
+          RUSTFLAGS: -Dwarnings
         run: |
           mold -run cargo build --all-features
 

editor/src/messages/portfolio/document/document_message.rs

@@ -16,7 +16,8 @@ use graphene_std::transform::Footprint;
 use graphene_std::vector::style::ViewMode;
 
 #[impl_message(Message, PortfolioMessage, Document)]
-#[derive(PartialEq, Clone, Debug, serde::Serialize, serde::Deserialize)]
+#[derive(derivative::Derivative, Clone, serde::Serialize, serde::Deserialize)]
+#[derivative(Debug, PartialEq)]
 pub enum DocumentMessage {
 	Noop,
 	// Sub-messages
@@ -157,6 +158,7 @@ pub enum DocumentMessage {
 	},
 	SetSnapping {
 		#[serde(skip)]
+		#[derivative(Debug = "ignore", PartialEq = "ignore")]
 		closure: Option<for<'a> fn(&'a mut SnappingState) -> &'a mut bool>,
 		snapping_state: bool,
 	},

editor/src/messages/portfolio/document/overlays/overlays_message.rs

@@ -2,10 +2,19 @@ use super::utility_types::{OverlayProvider, empty_provider};
 use crate::messages::prelude::*;
 
 #[impl_message(Message, DocumentMessage, Overlays)]
-#[derive(PartialEq, Clone, Debug, serde::Serialize, serde::Deserialize)]
+#[derive(derivative::Derivative, Clone, serde::Serialize, serde::Deserialize)]
+#[derivative(Debug, PartialEq)]
 pub enum OverlaysMessage {
 	Draw,
 	// Serde functionality isn't used but is required by the message system macros
-	AddProvider(#[serde(skip, default = "empty_provider")] OverlayProvider),
-	RemoveProvider(#[serde(skip, default = "empty_provider")] OverlayProvider),
+	AddProvider(
+		#[serde(skip, default = "empty_provider")]
+		#[derivative(Debug = "ignore", PartialEq = "ignore")]
+		OverlayProvider,
+	),
+	RemoveProvider(
+		#[serde(skip, default = "empty_provider")]
+		#[derivative(Debug = "ignore", PartialEq = "ignore")]
+		OverlayProvider,
+	),
 }

editor/src/messages/portfolio/document/utility_types/document_metadata.rs

@@ -294,15 +294,15 @@ impl LayerNodeIdentifier {
 	}
 
 	/// Iterator over all direct children (excluding self and recursive children)
-	pub fn children(self, metadata: &DocumentMetadata) -> AxisIter {
+	pub fn children(self, metadata: &DocumentMetadata) -> AxisIter<'_> {
 		AxisIter {
 			layer_node: self.first_child(metadata),
 			next_node: Self::next_sibling,
 			metadata,
 		}
 	}
 
-	pub fn downstream_siblings(self, metadata: &DocumentMetadata) -> AxisIter {
+	pub fn downstream_siblings(self, metadata: &DocumentMetadata) -> AxisIter<'_> {
 		AxisIter {
 			layer_node: Some(self),
 			next_node: Self::previous_sibling,
@@ -311,7 +311,7 @@ impl LayerNodeIdentifier {
 	}
 
 	/// All ancestors of this layer, including self, going to the document root
-	pub fn ancestors(self, metadata: &DocumentMetadata) -> AxisIter {
+	pub fn ancestors(self, metadata: &DocumentMetadata) -> AxisIter<'_> {
 		AxisIter {
 			layer_node: Some(self),
 			next_node: Self::parent,
@@ -320,7 +320,7 @@ impl LayerNodeIdentifier {
 	}
 
 	/// Iterator through all the last children, starting from self
-	pub fn last_children(self, metadata: &DocumentMetadata) -> AxisIter {
+	pub fn last_children(self, metadata: &DocumentMetadata) -> AxisIter<'_> {
 		AxisIter {
 			layer_node: Some(self),
 			next_node: Self::last_child,
@@ -329,7 +329,7 @@ impl LayerNodeIdentifier {
 	}
 
 	/// Iterator through all descendants, including recursive children (not including self)
-	pub fn descendants(self, metadata: &DocumentMetadata) -> DescendantsIter {
+	pub fn descendants(self, metadata: &DocumentMetadata) -> DescendantsIter<'_> {
 		DescendantsIter {
 			front: self.first_child(metadata),
 			back: self.last_child(metadata).and_then(|child| child.last_children(metadata).last()),

editor/src/messages/tool/common_functionality/transformation_cage.rs

@@ -578,15 +578,19 @@ impl BoundingBoxManager {
 			category,
 			TransformCageSizeCategory::Full | TransformCageSizeCategory::Narrow | TransformCageSizeCategory::ReducedLandscape
 		) {
-			horizontal_edges.map(|point| draw_handle(point, horizontal_angle));
+			for point in horizontal_edges {
+				draw_handle(point, horizontal_angle);
+			}
 		}
 
 		// Draw the vertical midpoint drag handles
 		if matches!(
 			category,
 			TransformCageSizeCategory::Full | TransformCageSizeCategory::Narrow | TransformCageSizeCategory::ReducedPortrait
 		) {
-			vertical_edges.map(|point| draw_handle(point, vertical_angle));
+			for point in vertical_edges {
+				draw_handle(point, vertical_angle);
+			}
 		}
 
 		let angle = quad
@@ -601,7 +605,9 @@ impl BoundingBoxManager {
 			category,
 			TransformCageSizeCategory::Full | TransformCageSizeCategory::ReducedBoth | TransformCageSizeCategory::ReducedLandscape | TransformCageSizeCategory::ReducedPortrait
 		) {
-			quad.0.map(|point| draw_handle(point, angle));
+			for point in quad.0 {
+				draw_handle(point, angle);
+			}
 		}
 
 		// Draw the flat line endpoint drag handles

frontend/src-tauri/.gitignore

@@ -1,3 +1,5 @@
 # Generated by Cargo
 # will have compiled files and executables
 /target/
+# Generated by tauri
+gen/