Review

Author: timon-schelling

desktop/src/lib.rs

@@ -31,7 +31,7 @@ pub fn start() -> ExitCode {
 		UiSetupResult::Ready(context) => context,
 		UiSetupResult::Helper(code) => return code,
 		UiSetupResult::Failed => {
-			eprintln!("Failed to set up the UI runtime");
+			tracing::error!("Failed to set up the UI runtime");
 			return ExitCode::FAILURE;
 		}
 	};
@@ -45,7 +45,8 @@ pub fn start() -> ExitCode {
 		.truncate(true)
 		.open(dirs::app_data_dir().join(APP_LOCK_FILE_NAME))
 	else {
-		panic!("Failed to open lock file.")
+		tracing::error!("Failed to open lock file.");
+		return ExitCode::FAILURE;
 	};
 	let mut lock = fd_lock::RwLock::new(lock_file);
 	let lock = match lock.try_write() {
@@ -123,8 +124,8 @@ pub fn start() -> ExitCode {
 						Some(message) => scheduler.schedule(AppEvent::DesktopWrapperMessage(message)),
 						None => tracing::error!("Failed to deserialize web message"),
 					},
-					UiEvent::InitFailed(error) => {
-						tracing::error!("UI initialization failed: {error}");
+					UiEvent::Failure(error) => {
+						tracing::error!("UI failure: {error}");
 						scheduler.schedule(AppEvent::UiCrashed);
 					}
 					UiEvent::Crashed => scheduler.schedule(AppEvent::UiCrashed),

desktop/ui/Cargo.toml

@@ -6,7 +6,6 @@ authors.workspace = true
 license.workspace = true
 edition.workspace = true
 
-
 [features]
 default = []
 embedded_resources = ["dep:graphite-desktop-embedded-resources"]

desktop/ui/src/frames/resample.wgsl

@@ -44,6 +44,9 @@ fn fs_main(in: VertexOutput) -> @location(0) vec4<f32> {
 	let nearest = floor(sample_pos - 0.5) + 0.5;
 	let t = sample_pos - nearest;
 
+	// Catmull-Rom spline interpolation based sampeling
+	// See https://gist.github.com/TheRealMJP/c83b8c0f46b63f3a88a5986f4fa982b1
+
 	let weight_before = t * (-0.5 + t * (1.0 - 0.5 * t));
 	let weight_nearest = 1.0 + t * t * (-2.5 + 1.5 * t);
 	let weight_next = t * (0.5 + t * (2.0 - 1.5 * t));

desktop/ui/src/ipc.rs

@@ -1,3 +1,5 @@
+// TODO: Consider inlining this file into internal as it is no longer use outside
+
 use cef::{Frame, ImplBinaryValue, ImplFrame, ImplListValue, ImplProcessMessage, ImplV8Context, ProcessId, V8Context, sys::cef_process_id_t};
 
 pub(crate) enum MessageType {

desktop/ui/src/lib.rs

@@ -233,7 +233,7 @@ pub enum UiEvent {
 	Frame(wgpu::Texture),
 	Cursor(Cursor),
 	Message(Vec<u8>),
-	InitFailed(String),
+	Failure(String),
 	Crashed,
 }
 

desktop/ui/src/remote/spawn.rs

@@ -367,7 +367,7 @@ fn handle_message(
 		EventMessage::InitFailed(e) => {
 			tracing::error!("CEF initialization failed in the host process: {e}");
 			died_reported.store(true, Ordering::SeqCst);
-			events.terminate(UiEvent::InitFailed(e.to_string()));
+			events.terminate(UiEvent::Failure(e.to_string()));
 		}
 		EventMessage::WebCommunicationInitialized => events.send(UiEvent::Ready),
 		EventMessage::WebMessage(message) => events.send(UiEvent::Message(message)),