Code review

Author: Keavon

Cargo.toml

@@ -189,7 +189,7 @@ graphite-editor = { opt-level = 1 }
 graphene-core-shaders = { opt-level = 1 }
 graphene-core = { opt-level = 1 }
 graphene-std = { opt-level = 1 }
-interpreted-executor = { opt-level = 1 }  # This is a mitigation for https://github.com/rustwasm/wasm-pack/issues/981 which is needed because the node_registry function is too large
+interpreted-executor = { opt-level = 1 } # This is a mitigation for https://github.com/rustwasm/wasm-pack/issues/981 which is needed because the node_registry function is too large
 graphite-proc-macros = { opt-level = 1 }
 image = { opt-level = 2 }
 rustc-hash = { opt-level = 3 }

node-graph/gcore/src/math/math_ext.rs

@@ -1,9 +1,8 @@
-use kurbo::{Line, PathSeg};
-
 use crate::math::quad::Quad;
 use crate::math::rect::Rect;
 use crate::subpath::Bezier;
 use crate::vector::misc::dvec2_to_point;
+use kurbo::{Line, PathSeg};
 
 pub trait QuadExt {
 	/// Get all the edges in the rect as linear bezier curves

node-graph/gcore/src/math/polynomial.rs

@@ -1,8 +1,7 @@
+use kurbo::PathSeg;
 use std::fmt::{self, Display, Formatter};
 use std::ops::{Add, AddAssign, Mul, MulAssign, Neg, Sub, SubAssign};
 
-use kurbo::PathSeg;
-
 /// A struct that represents a polynomial with a maximum degree of `N-1`.
 ///
 /// It provides basic mathematical operations for polynomials like addition, multiplication, differentiation, integration, etc.

node-graph/gcore/src/subpath/core.rs

@@ -1,7 +1,6 @@
-use crate::vector::misc::point_to_dvec2;
-
 use super::consts::*;
 use super::*;
+use crate::vector::misc::point_to_dvec2;
 use glam::DVec2;
 use kurbo::PathSeg;
 

node-graph/gcore/src/subpath/lookup.rs

@@ -1,10 +1,8 @@
-use crate::{
-	math::polynomial::pathseg_to_parametric_polynomial,
-	vector::algorithms::bezpath_algorithms::pathseg_length_centroid_and_length,
-	vector::algorithms::intersection::{filtered_all_segment_intersections, pathseg_self_intersections},
-};
-
-use super::{consts::MAX_ABSOLUTE_DIFFERENCE, *};
+use super::consts::MAX_ABSOLUTE_DIFFERENCE;
+use super::*;
+use crate::math::polynomial::pathseg_to_parametric_polynomial;
+use crate::vector::algorithms::bezpath_algorithms::pathseg_length_centroid_and_length;
+use crate::vector::algorithms::intersection::{filtered_all_segment_intersections, pathseg_self_intersections};
 use glam::DVec2;
 
 impl<PointId: Identifier> Subpath<PointId> {

node-graph/gcore/src/subpath/solvers.rs

@@ -1,6 +1,6 @@
 use crate::subpath::{Identifier, Subpath};
-use crate::vector::{algorithms::bezpath_algorithms::bezpath_is_inside_bezpath, misc::dvec2_to_point};
-
+use crate::vector::algorithms::bezpath_algorithms::bezpath_is_inside_bezpath;
+use crate::vector::misc::dvec2_to_point;
 use glam::DVec2;
 use kurbo::{Affine, BezPath, Shape};
 
@@ -40,13 +40,11 @@ impl<PointId: Identifier> Subpath<PointId> {
 	}
 
 	/// Returns `true` if this subpath is completely inside the `other` subpath.
-	/// <iframe frameBorder="0" width="100%" height="350px" src="https://graphite.rs/libraries/bezier-rs#subpath/inside-other/solo" title="Inside Other Subpath Demo"></iframe>
 	pub fn is_inside_subpath(&self, other: &Subpath<PointId>, accuracy: Option<f64>, minimum_separation: Option<f64>) -> bool {
 		bezpath_is_inside_bezpath(&self.to_bezpath(), &other.to_bezpath(), accuracy, minimum_separation)
 	}
 
 	/// Return the min and max corners that represent the bounding box of the subpath. Return `None` if the subpath is empty.
-	/// <iframe frameBorder="0" width="100%" height="300px" src="https://graphite.rs/libraries/bezier-rs#subpath/bounding-box/solo" title="Bounding Box Demo"></iframe>
 	pub fn bounding_box(&self) -> Option<[DVec2; 2]> {
 		self.iter()
 			.map(|bezier| bezier.bounding_box())

node-graph/gcore/src/subpath/structs.rs

@@ -1,6 +1,5 @@
 use crate::vector::algorithms::intersection::filtered_segment_intersections;
 use crate::vector::misc::{dvec2_to_point, handles_to_segment};
-
 use glam::{DAffine2, DVec2};
 use kurbo::{CubicBez, Line, PathSeg, QuadBez, Shape};
 use std::fmt::{Debug, Formatter, Result};
@@ -356,7 +355,6 @@ impl Bezier {
 	}
 
 	/// Create a linear bezier using the provided DVec2s as the start and end points.
-	/// <iframe frameBorder="0" width="100%" height="300px" src="https://graphite.rs/libraries/bezier-rs#bezier/constructor/solo" title="Constructor Demo"></iframe>
 	pub fn from_linear_dvec2(p1: DVec2, p2: DVec2) -> Self {
 		Bezier {
 			start: p1,

node-graph/gcore/src/subpath/transform.rs

@@ -39,7 +39,6 @@ impl<PointId: Identifier> Subpath<PointId> {
 	}
 
 	/// Returns a subpath that results from rotating this subpath around the origin by the given angle (in radians).
-	/// <iframe frameBorder="0" width="100%" height="325px" src="https://graphite.rs/libraries/bezier-rs#subpath/rotate/solo" title="Rotate Demo"></iframe>
 	pub fn rotate(&self, angle: f64) -> Subpath<PointId> {
 		let mut rotated_subpath = self.clone();
 

node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs

@@ -194,7 +194,6 @@ pub const DEFAULT_LUT_STEP_SIZE: usize = 10;
 
 /// Return a selection of equidistant points on the bezier curve.
 /// If no value is provided for `steps`, then the function will default `steps` to be 10.
-/// <iframe frameBorder="0" width="100%" height="350px" src="https://graphite.rs/libraries/bezier-rs#bezier/lookup-table/solo" title="Lookup-Table Demo"></iframe>
 pub fn pathseg_compute_lookup_table(segment: PathSeg, steps: Option<usize>, eucliean: bool) -> impl Iterator<Item = DVec2> {
 	let steps = steps.unwrap_or(DEFAULT_LUT_STEP_SIZE);
 

node-graph/gcore/src/vector/click_target.rs

@@ -1,14 +1,13 @@
+use super::algorithms::intersection::filtered_segment_intersections;
+use super::misc::dvec2_to_point;
 use crate::math::math_ext::QuadExt;
 use crate::math::quad::Quad;
 use crate::subpath::Subpath;
 use crate::vector::PointId;
+use crate::vector::misc::point_to_dvec2;
 use glam::{DAffine2, DMat2, DVec2};
 use kurbo::{Affine, ParamCurve, PathSeg, Point, Shape};
 
-use super::algorithms::intersection::filtered_segment_intersections;
-use super::misc::dvec2_to_point;
-use crate::vector::misc::point_to_dvec2;
-
 #[derive(Copy, Clone, Debug, PartialEq, serde::Serialize, serde::Deserialize)]
 pub struct FreePoint {
 	pub id: PointId,