Skip to content

Commit 6afec78

Browse files
committed
Code review fixes
1 parent deeb12d commit 6afec78

1 file changed

Lines changed: 5 additions & 14 deletions

File tree

editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ impl MessageHandler<GraphOperationMessage, GraphOperationMessageContext<'_>> for
347347
parent,
348348
insert_index,
349349
&graphite_gradient_stops,
350-
true,
351350
);
352351
}
353352
}
@@ -457,21 +456,13 @@ fn import_usvg_node(
457456
parent: LayerNodeIdentifier,
458457
insert_index: usize,
459458
graphite_gradient_stops: &HashMap<String, GradientStops>,
460-
is_root: bool,
461459
) {
462460
let layer = modify_inputs.create_layer(id);
463461

464-
if is_root {
465-
// Root layer uses the full move_layer_to_stack to handle interaction with existing nodes
466-
modify_inputs.network_interface.move_layer_to_stack(layer, parent, insert_index, &[]);
467-
modify_inputs.layer_node = Some(layer);
468-
if let Some(upstream_layer) = layer.next_sibling(modify_inputs.network_interface.document_metadata()) {
469-
modify_inputs.network_interface.shift_node(&upstream_layer.to_node(), IVec2::new(0, 3), &[]);
470-
}
471-
} else {
472-
// Non-root layers use lightweight wiring without push/collision logic
473-
modify_inputs.network_interface.move_layer_to_stack_for_import(layer, parent, insert_index, &[]);
474-
modify_inputs.layer_node = Some(layer);
462+
modify_inputs.network_interface.move_layer_to_stack(layer, parent, insert_index, &[]);
463+
modify_inputs.layer_node = Some(layer);
464+
if let Some(upstream_layer) = layer.next_sibling(modify_inputs.network_interface.document_metadata()) {
465+
modify_inputs.network_interface.shift_node(&upstream_layer.to_node(), IVec2::new(0, 3), &[]);
475466
}
476467

477468
match node {
@@ -507,7 +498,7 @@ fn import_usvg_node(
507498
import_usvg_path(modify_inputs, node, path, transform, layer, graphite_gradient_stops);
508499
}
509500
usvg::Node::Image(_image) => {
510-
warn!("Skip image")
501+
warn!("Skip image");
511502
}
512503
usvg::Node::Text(text) => {
513504
let font = Font::new(graphene_std::consts::DEFAULT_FONT_FAMILY.to_string(), graphene_std::consts::DEFAULT_FONT_STYLE.to_string());

0 commit comments

Comments
 (0)