Strip 'editor:click_target' override on Path node so direct edits restore precise hit testing

Author: Keavon

node-graph/libraries/core-types/src/table.rs

@@ -489,6 +489,13 @@ impl AttributeColumns {
 		self.columns.iter().find_map(|(k, column)| if k == key { column.get_any(index)?.downcast_ref::<T>() } else { None })
 	}
 
+	/// Removes the entire column for the given key, if present.
+	fn remove_column(&mut self, key: &str) {
+		if let Some(position) = self.columns.iter().position(|(k, _)| k == key) {
+			self.columns.remove(position);
+		}
+	}
+
 	/// Finds or creates a column for the given key and type, returning its position.
 	/// If a column with the key exists but has the wrong type, it is removed and replaced with a new column of the correct type, padded with defaults.
 	/// A newly created column is filled with `T::default()` for all existing rows.
@@ -753,6 +760,11 @@ impl<T> Table<T> {
 		self.attributes.set_value(key, index, value);
 	}
 
+	/// Removes the entire attribute column for the given key, if present.
+	pub fn remove_attribute(&mut self, key: &str) {
+		self.attributes.remove_column(key);
+	}
+
 	/// Runs the given closure on a mutable reference to the attribute value at the given row index,
 	/// creating the column with defaults if it doesn't exist, and returns the closure's result.
 	pub fn with_attribute_mut_or_default<U: Clone + Send + Sync + Default + Debug + PartialEq + CacheHash + 'static, R, F: FnOnce(&mut U) -> R>(&mut self, key: &str, index: usize, f: F) -> R {

node-graph/nodes/vector/src/vector_modification_nodes.rs

@@ -1,6 +1,6 @@
 use core_types::table::Table;
 use core_types::uuid::NodeId;
-use core_types::{ATTR_EDITOR_LAYER_PATH, ATTR_TRANSFORM, Ctx};
+use core_types::{ATTR_EDITOR_CLICK_TARGET, ATTR_EDITOR_LAYER_PATH, ATTR_TRANSFORM, Ctx};
 use glam::DAffine2;
 use graphic_types::Vector;
 use vector_types::vector::VectorModification;
@@ -15,6 +15,9 @@ async fn path_modify(_ctx: impl Ctx, mut vector: Table<Vector>, modification: Bo
 	}
 	modification.apply(vector.element_mut(0).expect("push should give one item"));
 
+	// Drop stale click-target override so hit testing uses the geometry the user is now editing
+	vector.remove_attribute(ATTR_EDITOR_CLICK_TARGET);
+
 	// Set the path to the encapsulating subgraph (drop our own trailing entry from `node_path`),
 	// matching the `path_of_subgraph` proto so editor tools can route data back to the parent layer.
 	let subgraph_path: Table<NodeId> = {