Skip to content

Commit a6f11f2

Browse files
KeavonCopilot
andcommitted
Add todo work
Co-authored-by: Copilot <copilot@github.com>
1 parent ead17a6 commit a6f11f2

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

  • node-graph/libraries/core-types/src

node-graph/libraries/core-types/src/table.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,12 @@ impl<T> Table<T> {
610610
columns: &mut self.attributes,
611611
}
612612
}
613+
614+
// TODO: Add an `iter_element_values` and `iter_element_values_mut`
615+
// TODO: Add an `iter_attribute_values(key)` and `iter_attribute_values_mut(key)`
616+
// TODO: Remove `iter` and `iter_mut`
617+
// TODO: Remove `TableRowIterMut` and probably `TableRowMut`
618+
// TODO: Maybe remove `TableRowRef` since it encourages per-row linear search of attributes for their key lookup in the storage Vec
613619
}
614620

615621
#[cfg(feature = "serde")]
@@ -693,6 +699,7 @@ impl<T> Default for Table<T> {
693699
}
694700
}
695701

702+
// TODO: Replace this with `CacheHash` and make it hash the attributes as well (we need to include the `CacheHash` trait bound in the type erasure)
696703
impl<T: Hash> Hash for Table<T> {
697704
fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
698705
for element in &self.element {

0 commit comments

Comments
 (0)