chore: code review

Author: Annonnymmousss

editor/src/messages/portfolio/document/graph_operation/utility_types.rs

@@ -263,6 +263,8 @@ impl<'a> ModifyInputsContext<'a> {
 				Some(NodeInput::value(TaggedValue::F64(typesetting.max_height.unwrap_or(100.)), false)),
 				Some(NodeInput::value(TaggedValue::F64(typesetting.tilt), false)),
 				Some(NodeInput::value(TaggedValue::TextAlign(typesetting.align), false)),
+				Some(NodeInput::value(TaggedValue::Bool(false), false)), // separate_glyph_elements
+				Some(NodeInput::value(TaggedValue::Bool(typesetting.hyphenate), false)),
 			]);
 		let transform = resolve_network_node_type("Transform").expect("Transform node does not exist").default_node_template();
 		let stroke = resolve_proto_node_type(graphene_std::vector_nodes::stroke::IDENTIFIER)

node-graph/nodes/gstd/src/text.rs

@@ -59,9 +59,9 @@ fn text<'i: 'n>(
 	/// To have an effect on a single line of text, *Max Width* must be set.
 	#[widget(ParsedWidgetOverride::Custom = "text_align")]
 	align: TextAlign,
-	hyphenate: bool,
 	/// Whether to split every letterform into its own vector path element. Otherwise, a single compound path is produced.
 	separate_glyph_elements: bool,
+	hyphenate: bool,
 ) -> Table<Vector> {
 	let typesetting = TypesettingConfig {
 		font_size: size,

node-graph/nodes/text/src/text_context.rs

@@ -15,13 +15,18 @@ thread_local! {
 	static THREAD_TEXT: RefCell<TextContext> = RefCell::new(TextContext::default());
 }
 
-static EN_US_DICT: OnceLock<Standard> = OnceLock::new();
+static EN_US_DICT: OnceLock<Option<Standard>> = OnceLock::new();
 
 fn get_dict_for_language(lang: Language) -> Option<&'static Standard> {
 	match lang {
 		Language::EnglishUS | Language::EnglishGB => EN_US_DICT
-			.get_or_init(|| Standard::from_embedded(Language::EnglishUS).expect("embed_all feature must be enabled"))
-			.into(),
+			.get_or_init(|| {
+				Standard::from_embedded(Language::EnglishUS).map_err(|err| {
+					log::error!("Failed to load hyphenation dictionary: {err}");
+					err
+				}).ok()
+			})
+			.as_ref(),
 		_ => None,
 	}
 }